Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: misc fixes #23

Merged
merged 11 commits into from
Aug 15, 2024
Merged

feat: misc fixes #23

merged 11 commits into from
Aug 15, 2024

Conversation

0xtiti
Copy link
Collaborator

@0xtiti 0xtiti commented Aug 15, 2024

closes ZKS-166
closes ZKS-167
closes ZKS-174
closes ZKS-175
closes ZKS-176
closes ZKS-177
closes ZKS-178
closes ZKS-171
closes ZKS-179

Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
z-kchain-hub-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 1:17pm

Copy link

linear bot commented Aug 15, 2024

ZKS-167 UI small bug

export const fetchEcosystemData = async () => {
  // temporary for mock data
  if (!API_URL) {
    return Promise.resolve(ecosystemMockData);
  }
  const res = await fetch(`${API_URL}/ecosystem`);
  if (!res.ok) {
    throw new Error('Failed to fetch ecosystem data');
  }
  return res.json();
};

to

export const fetchEcosystemData = async () => {
  // temporary for mock data
  if (!API_URL) {
    return Promise.resolve(ecosystemMockData);
  }
  const res = await fetch(`${API_URL}/metrics/ecosystem`);
  if (!res.ok) {
    throw new Error('Failed to fetch ecosystem data');
  }
  return await res.json();
};

ZKS-166 UI schemas

batchesInfo: {
    commited: number;
    verified: number;
    proved: number;
};

to

batchesInfo: {
    commited: string;
    verified: string;
    executed: string;
};
export interface TvlData {
  token: string;
  tokenName: string;
  total: number;
  imageUrl: string;
}

export interface ChainTvl {
  token: string;
  tokenName: string;
  total: number;
  imageUrl: string;
  price: number;
}

to

export interface TvlData {
  symbol: string;
  name: string;
  amountUsd: string;
  imageUrl: string;
}

export interface ChainTvl {
  symbol: string;
  name: string;
  amountUsd: string;
  imageUrl: string;
  price: string;
}

ZKS-174 Missing `cursor: pointer` in footer buttons

ZKS-175 Missing `cursor: pointer` in header logo

image.png

ZKS-176 Table headers shouldn't have `cursor: pointer`

ZKS-177 Missing hover effect in table rows

Figma:

image.png

ZKS-178 Missing hover effect in header and footer buttons

Figma:

image.png

0xArdy
0xArdy previously approved these changes Aug 15, 2024
Copy link
Member

@0xArdy 0xArdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing job! 🔥

@@ -14,7 +14,7 @@ export const LockedAssets = () => {
const goToTokensPage = () => {
router.push('/tokens');
};

console.log(ecosystemData.l1Tvl);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ddf3fab removed

@0xtiti 0xtiti merged commit 27cdd66 into dev Aug 15, 2024
6 checks passed
@0xtiti 0xtiti deleted the feat/misc-fixes branch August 15, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants