test: missing case for joinswapPoolAmountOut

defi-wonderland · Jul 24, 2024 · 634baee · 634baee
1 parent fcf63af
commit 634baee
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/test/unit/BPool/BPool_JoinswapPoolAmountOut.t.sol b/test/unit/BPool/BPool_JoinswapPoolAmountOut.t.sol
@@ -52,6 +52,13 @@ contract BPoolJoinswapPoolAmountOut is BPoolBase, BNum {
     bPool.joinswapPoolAmountOut(makeAddr('unknown token'), poolAmountOut, maxTokenIn);
   }
 
+  function test_RevertWhen_TokenAmountInIsZero() external {
+    // it should revert
+    vm.expectRevert(IBPool.BPool_InvalidTokenAmountIn.selector);
+    // using a small amount that rounds to zero
+    bPool.joinswapPoolAmountOut(tokenIn, 20, type(uint256).max);
+  }
+
   function test_RevertWhen_TokenAmountInExceedsMaxRatio() external {
     // it should revert
     vm.expectRevert(IBPool.BPool_TokenAmountInAboveMaxRatio.selector);

diff --git a/test/unit/BPool/BPool_JoinswapPoolAmountOut.tree b/test/unit/BPool/BPool_JoinswapPoolAmountOut.tree
@@ -5,6 +5,8 @@ BPool::JoinswapPoolAmountOut
 │   └── it should revert
 ├── when token in is not bound
 │   └── it should revert
+├── when token amount in is zero
+│   └── it should revert 
 ├── when token amount in exceeds max ratio
 │   └── it should revert 
 ├── when calculated token amount in is more than expected