feat: deprecating joins and exits

.forge-snapshots/exitPool.snap

@@ -1 +1 @@
-174743
+174776

.forge-snapshots/joinPool.snap

@@ -1 +1 @@
-138985
+138956

.forge-snapshots/newBCoWFactory.snap

@@ -1 +1 @@
-4899289
+4370972

.forge-snapshots/newBCoWPool.snap

@@ -1 +1 @@
-4042925
+3555439

.forge-snapshots/newBFactory.snap

@@ -1 +1 @@
-4140477
+3612809

.forge-snapshots/newBPool.snap

@@ -1 +1 @@
-3486610
+3000067

.forge-snapshots/settlementCoWSwap.snap

@@ -1 +1 @@
-215793
+215771

.forge-snapshots/settlementCoWSwapInverse.snap

@@ -1 +1 @@
-225641
+225619

.forge-snapshots/swapExactAmountIn.snap

@@ -1 +1 @@
-104920
+104942

.forge-snapshots/swapExactAmountInInverse.snap

@@ -1 +1 @@
-114589
+114765

src/contracts/BPool.sol

@@ -339,136 +339,6 @@ contract BPool is BToken, BMath, IBPool {
     _pushUnderlying(tokenOut, msg.sender, tokenAmountOut);
   }
 
-  /// @inheritdoc IBPool
-  function joinswapExternAmountIn(
-    address tokenIn,
-    uint256 tokenAmountIn,
-    uint256 minPoolAmountOut
-  ) external _logs_ _lock_ _finalized_ returns (uint256 poolAmountOut) {
-    if (!_records[tokenIn].bound) {
-      revert BPool_TokenNotBound();
-    }
-
-    Record storage inRecord = _records[tokenIn];
-    uint256 tokenInBalance = IERC20(tokenIn).balanceOf(address(this));
-    if (tokenAmountIn > bmul(tokenInBalance, MAX_IN_RATIO)) {
-      revert BPool_TokenAmountInAboveMaxRatio();
-    }
-
-    poolAmountOut =
-      calcPoolOutGivenSingleIn(tokenInBalance, inRecord.denorm, totalSupply(), _totalWeight, tokenAmountIn, _swapFee);
-    if (poolAmountOut < minPoolAmountOut) {
-      revert BPool_PoolAmountOutBelowMinPoolAmountOut();
-    }
-
-    emit LOG_JOIN(msg.sender, tokenIn, tokenAmountIn);
-
-    _mintPoolShare(poolAmountOut);
-    _pushPoolShare(msg.sender, poolAmountOut);
-    _pullUnderlying(tokenIn, msg.sender, tokenAmountIn);
-  }
-
-  /// @inheritdoc IBPool
-  function joinswapPoolAmountOut(
-    address tokenIn,
-    uint256 poolAmountOut,
-    uint256 maxAmountIn
-  ) external _logs_ _lock_ _finalized_ returns (uint256 tokenAmountIn) {
-    if (!_records[tokenIn].bound) {
-      revert BPool_TokenNotBound();
-    }
-
-    Record storage inRecord = _records[tokenIn];
-    uint256 tokenInBalance = IERC20(tokenIn).balanceOf(address(this));
-
-    tokenAmountIn =
-      calcSingleInGivenPoolOut(tokenInBalance, inRecord.denorm, totalSupply(), _totalWeight, poolAmountOut, _swapFee);
-
-    if (tokenAmountIn == 0) {
-      revert BPool_InvalidTokenAmountIn();
-    }
-    if (tokenAmountIn > maxAmountIn) {
-      revert BPool_TokenAmountInAboveMaxAmountIn();
-    }
-    if (tokenAmountIn > bmul(tokenInBalance, MAX_IN_RATIO)) {
-      revert BPool_TokenAmountInAboveMaxRatio();
-    }
-
-    emit LOG_JOIN(msg.sender, tokenIn, tokenAmountIn);
-
-    _mintPoolShare(poolAmountOut);
-    _pushPoolShare(msg.sender, poolAmountOut);
-    _pullUnderlying(tokenIn, msg.sender, tokenAmountIn);
-  }
-
-  /// @inheritdoc IBPool
-  function exitswapPoolAmountIn(
-    address tokenOut,
-    uint256 poolAmountIn,
-    uint256 minAmountOut
-  ) external _logs_ _lock_ _finalized_ returns (uint256 tokenAmountOut) {
-    if (!_records[tokenOut].bound) {
-      revert BPool_TokenNotBound();
-    }
-
-    Record storage outRecord = _records[tokenOut];
-    uint256 tokenOutBalance = IERC20(tokenOut).balanceOf(address(this));
-
-    tokenAmountOut =
-      calcSingleOutGivenPoolIn(tokenOutBalance, outRecord.denorm, totalSupply(), _totalWeight, poolAmountIn, _swapFee);
-
-    if (tokenAmountOut < minAmountOut) {
-      revert BPool_TokenAmountOutBelowMinAmountOut();
-    }
-    if (tokenAmountOut > bmul(tokenOutBalance, MAX_OUT_RATIO)) {
-      revert BPool_TokenAmountOutAboveMaxOut();
-    }
-
-    uint256 exitFee = bmul(poolAmountIn, EXIT_FEE);
-
-    emit LOG_EXIT(msg.sender, tokenOut, tokenAmountOut);
-
-    _pullPoolShare(msg.sender, poolAmountIn);
-    _burnPoolShare(bsub(poolAmountIn, exitFee));
-    _pushPoolShare(FACTORY, exitFee);
-    _pushUnderlying(tokenOut, msg.sender, tokenAmountOut);
-  }
-
-  /// @inheritdoc IBPool
-  function exitswapExternAmountOut(
-    address tokenOut,
-    uint256 tokenAmountOut,
-    uint256 maxPoolAmountIn
-  ) external _logs_ _lock_ _finalized_ returns (uint256 poolAmountIn) {
-    if (!_records[tokenOut].bound) {
-      revert BPool_TokenNotBound();
-    }
-
-    Record storage outRecord = _records[tokenOut];
-    uint256 tokenOutBalance = IERC20(tokenOut).balanceOf(address(this));
-    if (tokenAmountOut > bmul(tokenOutBalance, MAX_OUT_RATIO)) {
-      revert BPool_TokenAmountOutAboveMaxOut();
-    }
-
-    poolAmountIn =
-      calcPoolInGivenSingleOut(tokenOutBalance, outRecord.denorm, totalSupply(), _totalWeight, tokenAmountOut, _swapFee);
-    if (poolAmountIn == 0) {
-      revert BPool_InvalidPoolAmountIn();
-    }
-    if (poolAmountIn > maxPoolAmountIn) {
-      revert BPool_PoolAmountInAboveMaxPoolAmountIn();
-    }
-
-    uint256 exitFee = bmul(poolAmountIn, EXIT_FEE);
-
-    emit LOG_EXIT(msg.sender, tokenOut, tokenAmountOut);
-
-    _pullPoolShare(msg.sender, poolAmountIn);
-    _burnPoolShare(bsub(poolAmountIn, exitFee));
-    _pushPoolShare(FACTORY, exitFee);
-    _pushUnderlying(tokenOut, msg.sender, tokenAmountOut);
-  }
-
   /// @inheritdoc IBPool
   function getSpotPrice(address tokenIn, address tokenOut) external view _viewlock_ returns (uint256) {
     if (!_records[tokenIn].bound) {

src/interfaces/IBPool.sol

@@ -282,58 +282,6 @@ interface IBPool is IERC20 {
     uint256 maxPrice
   ) external returns (uint256 tokenAmountIn, uint256 spotPriceAfter);
 
-  /**
-   * @notice Joins a pool providing a single token in, specifying the exact amount of token given
-   * @param tokenIn The address of the token to swap in and join
-   * @param tokenAmountIn The amount of token to join
-   * @param minPoolAmountOut The minimum amount of pool token to receive
-   * @return poolAmountOut The amount of pool token received
-   */
-  function joinswapExternAmountIn(
-    address tokenIn,
-    uint256 tokenAmountIn,
-    uint256 minPoolAmountOut
-  ) external returns (uint256 poolAmountOut);
-
-  /**
-   * @notice Joins a pool providing a single token in, specifying the exact amount of pool tokens received
-   * @param tokenIn The address of the token to swap in and join
-   * @param poolAmountOut The amount of pool token to receive
-   * @param maxAmountIn The maximum amount of token to introduce to the pool
-   * @return tokenAmountIn The amount of token in introduced
-   */
-  function joinswapPoolAmountOut(
-    address tokenIn,
-    uint256 poolAmountOut,
-    uint256 maxAmountIn
-  ) external returns (uint256 tokenAmountIn);
-
-  /**
-   * @notice Exits a pool providing a specific amount of pool tokens in, and receiving only a single token
-   * @param tokenOut The address of the token to swap out and exit
-   * @param poolAmountIn The amount of pool token to burn
-   * @param minAmountOut The minimum amount of token to receive
-   * @return tokenAmountOut The amount of token received
-   */
-  function exitswapPoolAmountIn(
-    address tokenOut,
-    uint256 poolAmountIn,
-    uint256 minAmountOut
-  ) external returns (uint256 tokenAmountOut);
-
-  /**
-   * @notice Exits a pool expecting a specific amount of token out, and providing pool token
-   * @param tokenOut The address of the token to swap out and exit
-   * @param tokenAmountOut The amount of token to receive
-   * @param maxPoolAmountIn The maximum amount of pool token to burn
-   * @return poolAmountIn The amount of pool token burned
-   */
-  function exitswapExternAmountOut(
-    address tokenOut,
-    uint256 tokenAmountOut,
-    uint256 maxPoolAmountIn
-  ) external returns (uint256 poolAmountIn);
-
   /**
    * @notice Gets the spot price of tokenIn in terms of tokenOut
    * @param tokenIn The address of the token to swap in