fix: feedback from review

defi-wonderland · Jul 22, 2024 · c4e89a2 · c4e89a2
1 parent 15eac0e
commit c4e89a2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/test/unit/BCoWPool/BCoWPool.t.sol b/test/unit/BCoWPool/BCoWPool.t.sol
@@ -34,6 +34,10 @@ contract BCoWPool is BCoWPoolBase {
     assumeNotForgeAddress(_settler);
     vm.mockCall(_settler, abi.encodePacked(ISettlement.domainSeparator.selector), abi.encode(_separator));
     vm.mockCall(_settler, abi.encodePacked(ISettlement.vaultRelayer.selector), abi.encode(_relayer));
+    // it should query the solution settler for the domain separator
+    vm.expectCall(_settler, abi.encodePacked(ISettlement.domainSeparator.selector));
+    // it should query the solution settler for the vault relayer
+    vm.expectCall(_settler, abi.encodePacked(ISettlement.vaultRelayer.selector));
     MockBCoWPool pool = new MockBCoWPool(_settler, _appData);
     // it should set the solution settler
     assertEq(address(pool.SOLUTION_SETTLER()), _settler);

diff --git a/test/unit/BCoWPool/BCoWPool.tree b/test/unit/BCoWPool/BCoWPool.tree
@@ -1,7 +1,9 @@
 BCoWPool::Constructor
 └── when called
     ├── it should set the solution settler
+    ├── it should query the solution settler for the domain separator
     ├── it should set the domain separator
+    ├── it should query the solution settler for the vault relayer
     ├── it should set the vault relayer
     └── it should set the app data