fix: inverse bool bug in validation

defi-wonderland · May 17, 2024 · d6da242 · d6da242
1 parent b5f97d8
commit d6da242
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/contracts/BaseBCoWPool.sol b/src/contracts/BaseBCoWPool.sol
@@ -209,7 +209,7 @@ abstract contract BaseBCoWPool is IERC1271 {
     (GPv2Order.Data memory order, TradingParams memory tradingParams) =
       abi.decode(signature, (GPv2Order.Data, TradingParams));
 
-    if (tradingParamsHash[hash(tradingParams)]) {
+    if (!tradingParamsHash[hash(tradingParams)]) {
       revert TradingParamsDoNotMatchHash();
     }
     bytes32 orderHash = order.hash(solutionSettlerDomainSeparator);

diff --git a/test/integration/PoolSwap.t.sol b/test/integration/PoolSwap.t.sol
@@ -50,6 +50,11 @@ abstract contract PoolSwapIntegrationTest is Test, GasSnapshot {
     pool.bind(address(tokenB), 1e18, 8e18); // 80%
 
     pool.finalize();
+
+    BaseBCoWPool(address(pool)).enableTrading(
+      BaseBCoWPool.TradingParams({sellToken: tokenA, buyToken: tokenB, appData: ''})
+    );
+
     vm.stopPrank();
   }