feat: adding live balances to bPool #15
Conversation
There was a problem hiding this comment.
Should document somewhere why you're making this change. It looks like it does what you intend it to do (automatic gulping).
In this simpler contract, we're not handling ETH or making external calls, so there shouldn't be any reentrancy issues (e.g., where people could send tokens and change the balances in the middle of an operation).
src/contracts/BPool.sol
Outdated
|
|
||
| _pushUnderlying(token, msg.sender, bsub(tokenBalance, tokenExitFee)); | ||
| _pushUnderlying(token, _factory, tokenExitFee); | ||
| } | ||
|
|
||
| // NOTE: deprecated method, as balances are calculated on-the-fly |
There was a problem hiding this comment.
Could gulp just be removed, as we're doing it continuously/implicitly now? Are we expecting people to call this? Nobody is really using V1, so I don't think we need to worry about compatibility with existing pools.
There was a problem hiding this comment.
we can totally deprecate it 👌
was thinking that if there's the chance of a contract already developed that does transfer + gulp, making gulp a no-operation would avoid any revert
but, if there's no current implementation, we can just delete the gulp method pointer
No description provided.