feat: add btt tests for BCoWPool commit #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wei3erHase
reviewed
Jul 17, 2024
test/unit/BCoWPool/BCoWPool.tree
Outdated
| ├── when sender is not solution settler | ||
| │ └──it should revert | ||
| └── when sender is solution settler | ||
| ├── when reentrancy lock is set |
There was a problem hiding this comment.
other way around? 1st reentrancy is checked, then the sender
There was a problem hiding this comment.
i'd go for:
when reentrancy lock is set -> should revert
when sender is not solution settler -> should revert
when called (or preconditions are met) -> should set the reentrancy lock
wei3erHase
reviewed
Jul 17, 2024
test/unit/BCoWPool/BCoWPool.t.sol
Outdated
Comment on lines
26
to
30
| function test_WhenPreconditionsAreMet() external whenPreconditionsAreMet { | ||
| function test_FinalizeWhenPreconditionsAreMet() external whenPreconditionsAreMet { |
There was a problem hiding this comment.
why are we changing this line? is it that single tree bulloak skips the method?
0xteddybear
force-pushed
the
test/btt-commit
branch
from
96aa3d6 to
4865e04
Compare
wei3erHase
reviewed
Jul 22, 2024
| @@ -6,3 +6,11 @@ BCoWPool::_afterFinalize | |||
| │ └── it returns | |||
| └── when factorys logBCoWPool reverts | |||
| └── it emits a COWAMMPoolCreated event | |||
|
|
|||
| BCoWPool::Commit | |||
There was a problem hiding this comment.
i don't get why we need to capitalize, it's not on BPool.tree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.