Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: btt tests for bcowpool constructor #163

Merged
merged 29 commits into from
Jul 23, 2024
Merged

Conversation

0xteddybear
Copy link

No description provided.

└── when called
├── it should set the solution settler
├── it should set the domain separator
├── it should set the vault relayer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing the external call? should query solution settler for vault relayer + should query solution settler for app data

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ask" doesn't sound good

@0xteddybear 0xteddybear force-pushed the test/btt-bcowpool-constructor branch from 2eec445 to ac4399e Compare July 18, 2024 15:44
Base automatically changed from test/btt-finalize to dev July 22, 2024 17:00
@0xteddybear 0xteddybear requested a review from wei3erHase July 22, 2024 17:50
wei3erHase
wei3erHase previously approved these changes Jul 22, 2024
Copy link
Member

@wei3erHase wei3erHase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

wei3erHase
wei3erHase previously approved these changes Jul 23, 2024
Copy link
Member

@wei3erHase wei3erHase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 !!

Copy link
Member

@wei3erHase wei3erHase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@wei3erHase wei3erHase merged commit dad92aa into dev Jul 23, 2024
4 checks passed
@wei3erHase wei3erHase deleted the test/btt-bcowpool-constructor branch July 23, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants