feat: adding btt test for joinswap extern amount in #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wei3erHase
reviewed
Jul 18, 2024
Comment on lines
13
to
19
| ├── it emits LOG_CALL event | ||
| ├── it sets the reentrancy lock | ||
| ├── it emits LOG_JOIN event for token | ||
| ├── it calls _pullUnderlying for token | ||
| ├── it mints the pool shares | ||
| ├── it sends pool shares to caller | ||
| └── it clears the reentrancy lock |
There was a problem hiding this comment.
queries token in balance? i feel we're forgetting it everywhere
wei3erHase
reviewed
Jul 18, 2024
| uint256 public totalWeight = 10e18; | ||
| uint256 public tokenInBalance = 50e18; | ||
|
|
||
| // (((tokenAmountIn*(1-(1-tokenInWeight/totalWeight)*MIN_FEE)+tokenInBalance)/tokenInBalance)^(tokenInWeight/totalWeight))*INIT_POOL_SUPPLY - INIT_POOL_SUPPLY |
There was a problem hiding this comment.
can we reduce this formula to what's described in BMath? like, using wi or wT instead of full variable names, perhaps we can do this accross all tests
There was a problem hiding this comment.
we could, but for that we could reference bmath directly. In these comments I explicitly implement the formulae as defined by bmath in a notation that's easily executable, using the same variable names that'll be found in the code, as both a sanity check and the way to independently compute them (this one got me searching for alternatives tobc tho, because of the non-integer exponent)
wei3erHase
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.