feat: adding btt tests for bToken #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xteddybear
reviewed
Jul 19, 2024
| BToken::increaseApproval | ||
| ├── when sender is address zero | ||
| │ └── it should revert | ||
| ├── when spender is address zero |
There was a problem hiding this comment.
how could we get to this? I imagine the assertion was added to OZ to avoid programeer errors when calling the internal method, but is there any context in where an external caller could beaddress(0)?
There was a problem hiding this comment.
hmmm is not, but is an actual possible branch, it actually happens inside _approve so tbh i wouldn't care so much for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.