Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add btt tests for exitswap pool amount in #169

Merged
merged 8 commits into from
Jul 22, 2024

Conversation

0xteddybear
Copy link

No description provided.

├── it emits LOG_CALL event
├── it sets the reentrancy lock
├── it queries token out balance
├── it emits LOG_EXIT event for every token
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not

Comment on lines 94 to 95
// it emits LOG_EXIT event for every token
emit IBPool.LOG_EXIT(address(this), tokenOut, expectedAmountOut);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Member

@wei3erHase wei3erHase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol typos in the branch definitions, other than that looks ok

Base automatically changed from test/btt-bpool-joinswapExternAmountIn to dev July 22, 2024 09:35
Copy link
Member

@wei3erHase wei3erHase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now! 🚀

@wei3erHase wei3erHase changed the title Test/btt exitswap pool amount in feat: add btt tests for exitswap pool amount in Jul 22, 2024
@wei3erHase wei3erHase merged commit cb92f9d into dev Jul 22, 2024
4 checks passed
@wei3erHase wei3erHase deleted the test/btt-exitswapPoolAmountIn branch July 22, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants