test: unit tests for BFactory.sol #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xAustrian
changed the title
wei3erHase
reviewed
May 3, 2024
src/contracts/test/TToken.sol
Outdated
| @@ -127,7 +127,7 @@ contract TToken { | |||
| function transferFrom(address src, address dst, uint amt) external returns (bool) { | |||
| require(msg.sender == src || amt <= _allowance[src][msg.sender], "ERR_BTOKEN_BAD_CALLER"); | |||
| _move(src, dst, amt); | |||
| if (msg.sender != src && _allowance[src][msg.sender] != uint256(-1)) { | |||
| if (msg.sender != src && _allowance[src][msg.sender] != uint256(int(-1))) { | |||
There was a problem hiding this comment.
use type(uint256).max instead 🙏
wei3erHase
reviewed
May 3, 2024
There was a problem hiding this comment.
i think this is sth that may improve on the way forward, but we could have standarized names for testing, such as:
test_Set_Owner
test_Set_IsBPool
test_Emit_Logs
test_Returns_Pool
and so, in that way, we can then filter them out for example to be run individually, or by topic
wei3erHase
reviewed
May 3, 2024
test/unit/BFactory.t.sol
Outdated
| * @notice Test that a valid pool is present on the mapping | ||
| */ | ||
| function test_validPoolIsBPool() public { | ||
| BPool _pool = bFactory.newBPool(); |
There was a problem hiding this comment.
can we avoid deploying a new pool but instead overwriting the storage with cheatcodes? 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.