Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: bPool unit tests scaffolding #8

Merged
merged 21 commits into from
May 9, 2024
Merged

test: bPool unit tests scaffolding #8

merged 21 commits into from
May 9, 2024

Conversation

0xAustrian
Copy link

No description provided.

@0xAustrian 0xAustrian self-assigned this May 3, 2024
wei3erHase
wei3erHase reviewed May 6, 2024
View reviewed changes
Copy link
Member

@wei3erHase wei3erHase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing! 👏
looking good so far, let's remember to prioritize critical methods:

  • joinPool
  • exitPool
  • swapExact*
  • joinSwap*
  • exitSwap*

@0xAustrian 0xAustrian changed the title test: wip initial test structure test: BPool.sol unit tests May 6, 2024
wei3erHase
wei3erHase reviewed May 7, 2024
View reviewed changes
Copy link
Member

@wei3erHase wei3erHase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pointing in the right direction fren!

package.json Show resolved Hide resolved
test/unit/BPool.t.sol Outdated Show resolved Hide resolved
test/unit/BPool.t.sol Outdated Show resolved Hide resolved
test/unit/BPool.t.sol Outdated Show resolved Hide resolved
wei3erHase
wei3erHase reviewed May 8, 2024
View reviewed changes
Copy link
Member

@wei3erHase wei3erHase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing! 1st happy paths are the toughest ones

test/unit/BPool.t.sol Outdated Show resolved Hide resolved
foundry.toml Show resolved Hide resolved
test/unit/BPool.t.sol Outdated Show resolved Hide resolved
@0xAustrian 0xAustrian marked this pull request as ready for review May 8, 2024 19:47
wei3erHase
wei3erHase reviewed May 8, 2024
View reviewed changes
test/unit/BPool.t.sol Outdated Show resolved Hide resolved
test/unit/BPool.t.sol Outdated Show resolved Hide resolved
wei3erHase
wei3erHase reviewed May 9, 2024
View reviewed changes
test/unit/BPool.t.sol Outdated Show resolved Hide resolved
wei3erHase
wei3erHase reviewed May 9, 2024
View reviewed changes
test/unit/BPool.t.sol Outdated Show resolved Hide resolved
wei3erHase
wei3erHase reviewed May 9, 2024
View reviewed changes
test/unit/BPool.t.sol Outdated Show resolved Hide resolved
@wei3erHase
fix: moving happy path to specific test contract (#11)
4d31793 
* fix: moving happy path to specific test contract

* fix: linter errors
@wei3erHase wei3erHase changed the title test: BPool.sol unit tests test: bPool unit tests scaffolding May 9, 2024
@wei3erHase
feat: adding smock package (#10)
922e19c 
* feat: adding smock package

* fix: moving happy path to specific test contract

* fix: linter errors

* feat: implementing smock to unit test

* fix: adding smock to ci

* fix: ci

* fix: addressing comments in pr
wei3erHase
wei3erHase approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@wei3erHase wei3erHase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sehr schön 👏

@0xAustrian 0xAustrian merged commit 1a87b42 into dev May 9, 2024
4 checks passed
@0xAustrian 0xAustrian deleted the test/bpool-unit-tests branch May 9, 2024 12:40
wei3erHase
wei3erHase reviewed May 9, 2024
View reviewed changes
test/unit/BPool.t.sol
Comment on lines +20 to +21
uint256 internal constant _RECORD_MAPPING_SLOT_NUMBER = 10;
uint256 internal constant _TOKENS_ARRAY_SLOT_NUMBER = 9;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups, let's remember to remove 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wei3erHase wei3erHase wei3erHase approved these changes

Assignees

@0xAustrian 0xAustrian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xAustrian @wei3erHase