Skip to content

Commit

Permalink
fix: pr comments
Browse files Browse the repository at this point in the history
  • Loading branch information
0xkenj1 committed Oct 23, 2024
1 parent 3991da5 commit 41cd088
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 26 deletions.
2 changes: 1 addition & 1 deletion apps/indexer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
},
"dependencies": {
"chai": "4.3.10",
"envio": "2.4.1",
"envio": "2.5.2",
"ethers": "6.8.0",
"yaml": "2.5.1"
},
Expand Down
42 changes: 21 additions & 21 deletions apps/indexer/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export class RoleGrantedHandler implements IEventHandler<"Registry", "RoleGrante
) {}
async handle(): Promise<Changeset[]> {
const { projectRepository } = this.dependencies;
const role = this.event.params.role.toLocaleLowerCase();
const role = this.event.params.role.toLowerCase();
if (role === ALLO_OWNER_ROLE) {
return [];
}
Expand All @@ -26,8 +26,8 @@ export class RoleGrantedHandler implements IEventHandler<"Registry", "RoleGrante
const project = await projectRepository.getProjectById(this.chainId, role);

// The member role for an Allo V2 profile, is the profileId itself.
// If a project exists with that id, we create the member role
// If it doesn't exists we create a pending project role. This can happens
// If a project exist with that id, we create the member role
// If it doesn't exist we create a pending project role. This can happen
// when a new project is created, since in Allo V2 the RoleGranted event for a member is
// emitted before the ProfileCreated event.
if (project) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ describe("RegistryProcessor", () => {
vi.resetAllMocks();
});

it("should throw UnsupportedEventException for unsupported events", async () => {
it("throws UnsupportedEventException for unsupported events", async () => {
const event: ProtocolEvent<"Registry", RegistryEvent> = {
eventName: "UnsupportedEvent",
} as unknown as ProtocolEvent<"Registry", RegistryEvent>;
Expand Down

0 comments on commit 41cd088

Please sign in to comment.