Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/providers-and-logger #12

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Feat/providers-and-logger #12

merged 4 commits into from
Oct 16, 2024

Conversation

0xkenj1
Copy link
Collaborator

@0xkenj1 0xkenj1 commented Oct 16, 2024

Description

  • Abstraction for interactions with EVM chains in chain-providers
  • Generic Logger in shared
  • Fixed tests naming
  • Fixed tsconfig to include test in check-types script
  • Fixed typing issues on pricing tests

Checklist before requesting a review

  • I have conducted a self-review of my code.
  • I have conducted a QA.
  • If it is a core feature, I have included comprehensive tests.

@0xkenj1 0xkenj1 merged commit 24ce18e into dev Oct 16, 2024
11 checks passed
@0xkenj1 0xkenj1 deleted the feat/providers-and-logger branch October 16, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xyaco 0xyaco 0xyaco approved these changes

@0xnigir1 0xnigir1 0xnigir1 approved these changes

@jahabeebs jahabeebs Awaiting requested review from jahabeebs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xkenj1 @0xnigir1 @0xyaco