Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: local deployment #26

Merged
merged 15 commits into from
Nov 8, 2024
Merged

feat: local deployment #26

merged 15 commits into from
Nov 8, 2024

Conversation

0xkenj1
Copy link
Collaborator

@0xkenj1 0xkenj1 commented Nov 7, 2024

🤖 Linear

Closes GIT-82

Description

Set up for local deployment and short docs.

Checklist before requesting a review

  • I have conducted a self-review of my code.
  • I have conducted a QA.
  • If it is a core feature, I have included comprehensive tests.

Copy link

linear bot commented Nov 7, 2024

GIT-82 Local deployment

@0xkenj1 0xkenj1 requested a review from 0xnigir1 November 7, 2024 14:08
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file should be deleted right? is the Dockerfile for the Indexer not the processing service

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete too

env_file:
- .env
environment:
POSTGRES_DB: ${ENVIO_PG_DATABASE}
POSTGRES_USER: ${ENVIO_PG_USER}
POSTGRES_PASSWORD: ${ENVIO_POSTGRES_PASSWORD}
healthcheck:
test: ["CMD-SHELL", "pg_isready -U ${DATALAYER_PG_USER}"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test: ["CMD-SHELL", "pg_isready -U ${DATALAYER_PG_USER}"]
test: ["CMD-SHELL", "pg_isready -U ${ENVIO_PG_USER}"]

@@ -69,7 +70,7 @@ export class EnvioIndexerClient implements IIndexerClient {
if (error instanceof InvalidIndexerResponse) {
throw error;
}
throw new IndexerClientError(JSON.stringify(error));
throw new IndexerClientError(JSON.stringify(error, Object.getOwnPropertyNames(error)));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥴 xd

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be fixed on the following pr

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should update .env.example file too

README.md Outdated

```
docker-compose up -d --build
```

Once the deployment is complete, you can access Hasura by navigating to:
2. After starting Docker Compose, run the following command to apply the database migrations:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should clarify that you need to setup the .env file inside apps/scripts folder before running the scripts

@0xkenj1 0xkenj1 force-pushed the feat/local-deployment branch from f89c568 to 070a503 Compare November 7, 2024 20:23
@0xkenj1 0xkenj1 merged commit 07e2da0 into dev Nov 8, 2024
6 checks passed
@0xkenj1 0xkenj1 deleted the feat/local-deployment branch November 8, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants