feat: logger #27
Merged
feat: logger #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jahabeebs
previously approved these changes
Nov 7, 2024
apps/processing/.dockerignore
Outdated
| .git | ||
| .gitignore | ||
| *.md | ||
| generated |
There was a problem hiding this comment.
will we have a .env in this dir?
| isNativeError(error) ? error.stack : undefined, | ||
| ); | ||
| const errorMessage = | ||
| `Coingecko API error: failed to fetch token price` + |
There was a problem hiding this comment.
maybe leave a blank space after price so it's separated from the stringified error
0xkenj1
dismissed
jahabeebs’s stale review
The merge-base changed after approval.
0xnigir1
reviewed
Nov 8, 2024
jahabeebs
approved these changes
Nov 8, 2024
0xnigir1
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GIT-116
Description
Replace
consolecalls with shared logger.Checklist before requesting a review