feat: registry handlers #31
Conversation
| ) {} | ||
| async handle(): Promise<Changeset[]> { |
There was a problem hiding this comment.
| ) {} | |
| async handle(): Promise<Changeset[]> { | |
| ) {} | |
| /* @inheritdoc */ | |
| async handle(): Promise<Changeset[]> { |
or a more specific description
| /** | ||
| * Handles the ProfileMetadataUpdated event for the Registry contract from Allo protocol. | ||
| */ |
There was a problem hiding this comment.
i like adding here a general overview of the main actions performed by the handler
for example for PoolCreatedHandler
/**
* Handles the PoolCreated event for the Allo protocol.
*
* This handler performs the following core actions when a new pool is created:
* - Retrieves the metadata associated with the pool
* - Determines the correct token address, handling native tokens appropriately.
* - Extracts the correct strategy information from the provided strategy ID.
* - Calculates the funded amount in USD based on the token's pricing.
* - Creates a new round object
*/
There was a problem hiding this comment.
this is great, i saw it on your prs 💯
There was a problem hiding this comment.
ditto for description and inheritdoc
There was a problem hiding this comment.
ditto for description and inheritdoc
| if (!project) { | ||
| return []; | ||
| } |
There was a problem hiding this comment.
ditto for description and inheritdoc
| if (!parsedMetadata.success) { | ||
| // logger.warn({ | ||
| // msg: `ProfileMetadataUpdated: Failed to parse metadata`, | ||
| // event, | ||
| // metadataCid, | ||
| // metadata, | ||
| // }); | ||
| return []; | ||
| } |
There was a problem hiding this comment.
should we throw or return empty?
There was a problem hiding this comment.
missing test cases for the newly created handlers
| @@ -1,6 +1,6 @@ | |||
| import { Address, ChainId } from "@grants-stack-indexer/shared"; | |||
|
|
|||
| export type ProjectType = "canonical" | "linked"; | |||
| export type ProjectType = "canonical" | "linked" | "unknown"; | |||
There was a problem hiding this comment.
i thought we wouldn't use "unknown" as value
packages/processors/src/processors/registry/handlers/profileNameUpdated.handler.ts
Show resolved
Hide resolved
| readonly chainId: ChainId, | ||
| private dependencies: Dependencies, | ||
| ) {} | ||
| async handle(): Promise<Changeset[]> { |
| @@ -5,3 +5,9 @@ export class ProjectNotFound extends Error { | |||
| super(`Project not found for chainId: ${chainId} and anchorAddress: ${anchorAddress}`); | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I guess the above exception should be called ProjectByAnchorNotFound since there are multiple of these but just a suggestion
| metadata: [0, mockCid], | ||
| profileId: "mockProfileId", | ||
| }, | ||
| // Add other necessary event properties here |
| @@ -9,7 +9,7 @@ import { | |||
| } from "@grants-stack-indexer/shared"; | |||
|
|
|||
| import { ProcessorDependencies } from "../../../src/internal.js"; | |||
| import { RoleGrantedHandler } from "../../../src/registry/handlers/index.js"; // Adjust path if needed | |||
| import { RoleGrantedHandler } from "../../../src/processors/registry/handlers/index.js"; // Adjust path if needed | |||
|
|
||
| const handler = new RoleRevokedHandler(mockEvent, mockChainId, mockDependencies); | ||
|
|
||
| await expect(handler.handle()).rejects.toThrow(error); |
There was a problem hiding this comment.
I think we could specifically check that the new custom error is thrown here
🤖 Linear
Closes GIT-138 GIT-145 GIT-146 GIT-147 GIT-148
Description
All Registry contract event handlers.
Checklist before requesting a review