feat: direct allocation strategy & direct allocated event handler #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xkenj1
reviewed
Nov 14, 2024
| this.dependencies, | ||
| ).handle(); | ||
| default: | ||
| throw new UnsupportedEventException("Strategy", event.eventName); |
There was a problem hiding this comment.
we improve this error by providing strategyName as optional or maybe create a new custom error for strategies. wdyt ?
There was a problem hiding this comment.
i buy the first option 🫡
Comment on lines
+45
to
+52
| const round = await roundRepository.getRoundByStrategyAddressOrThrow( | ||
| this.chainId, | ||
| strategyAddress, | ||
| ); | ||
| const project = await projectRepository.getProjectByIdOrThrow( | ||
| this.chainId, | ||
| this.event.params.profileId, | ||
| ); |
jahabeebs
approved these changes
Nov 14, 2024
| import { BaseStrategyHandler } from "../index.js"; | ||
| import { DirectAllocatedHandler } from "./handlers/index.js"; | ||
|
|
||
| const STRATEGY_NAME = "allov2.DirectAllocationStrategy"; |
There was a problem hiding this comment.
as we add more of these we should extract these into one place
There was a problem hiding this comment.
yeah probably, one more to go (for now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GIT-159
Description
DirectAllocationStrategyhandlerDirectAllocatedevent handler for DirectAllocationStrategyChecklist before requesting a review