feat: direct grants simple event handlers #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xkenj1
previously approved these changes
Nov 20, 2024
| * - Links the application to both the project and round | ||
| */ | ||
|
|
||
| export class DGSimpleRegisteredHandler |
There was a problem hiding this comment.
Suggested change
| export class DGSimpleRegisteredHandler | |
| export class DirectGrantsSimpleRegisteredHandler |
may we use complete names for strategies ? or at least use the same for strategy and event handlers :)
Look here packages/processors/src/processors/strategy/directGrantsSimple/directGrantsSimple.handler.ts
There was a problem hiding this comment.
i renamed to DGSimple to follow the convention on the other strategies
jahabeebs
previously approved these changes
Nov 20, 2024
| import { createMockEvent } from "../../../mocks/index.js"; | ||
|
|
||
| // function createMockEvent( | ||
| // overrides: DeepPartial<ProcessorEvent<"Strategy", "RegisteredWithSender">> = {}, |
0xkenj1
approved these changes
Nov 20, 2024
jahabeebs
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GIT-161 GIT-163
Description
DirectGrantsSimpleStrategyhandler and events handlers:RegisteredTimestampsUpdatedDistributedChecklist before requesting a review