feat: fetch events by src addresses

[0xnigir1]

🤖 Linear

Closes GIT-205

Description

We want to be able to fetch all events for a now-handleable strategy, so we add a method to fetch all events between Genesis and lastProcessedEvent for a group of src addresses (all that corresponds to a strategyId)

Checklist before requesting a review

• I have conducted a self-review of my code.
• I have conducted a QA.
• If it is a core feature, I have included comprehensive tests.

[linear]

GIT-205 Fetch events from Genesis to lastProcessedEvent for newly handled strategies

[0xyaco]

As a sidenote, you got the fetchEventsByBlockNumberAndLogIndex method that receives multiple parameters and you got this method that receives a params object.

Is there any particular reason for that?

And another question 👉 have you ever considered leveraging some kind of query builder pattern for the event fetcher? You could end up with a cool class:

const query = EventsFetcher.buildQuery()
  .withChainId(chainId)
  .withSrcAddressess(addresses)
  .withBlockNumber(blockNumber)
  ...

If you envision having more fetchEventsBy... methods, I'd consider this hehe

[0xnigir1]

regarding first, now that you mention that you're right, originally i wrote the method only with to param but when adding the from actually both methods can be combined into one

regarding second, i like query builders 😄 but i don't think we will benefit too much for now

[0xnigir1]

i keep the old method until i integrate it with the rest of the code cuz if not i'll break everything

[0xyaco]

What if from is {}?

[0xnigir1]

good catch

[0xkenj1]

just smoll comments in docs and method signature

[0xkenj1]

should it be like this ?

Suggested change

	from?: {
	blockNumber?: number;
	logIndex?: number;
	};
	to: {
	blockNumber: number;
	logIndex: number;
	from: {
	blockNumber: number;
	logIndex: number;
	};
	to?: {
	blockNumber: number;
	logIndex: number;

[0xkenj1]

is this ok ?

[0xyaco]

This might not be relevant as you might be using this provider in a super specific way but how would you get all events from a single block?

I can only think of something like this:

from: { blockNumber: x, logIndex: 0 }
to: { blockNumber: x + 1, logIndex: 0 }

But it misses the log 0 from block x and includes log 0 from block x + 1.

[0xnigir1]

didn't think of this case since we fetch events individually (blockNumber and logIndex), not by blocks but i get your point. i will add it to tech debt