Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add L2 standard bridge interop unit tests #13

Merged
merged 5 commits into from
Aug 8, 2024
Merged

test: add L2 standard bridge interop unit tests #13

merged 5 commits into from
Aug 8, 2024

Conversation

agusduha
Copy link
Member

@agusduha agusduha commented Aug 6, 2024

Closes OPT-176

@agusduha agusduha requested review from 0xng and 0xDiscotech August 6, 2024 20:42
@agusduha agusduha self-assigned this Aug 6, 2024
@linear Linear
Copy link

linear bot commented Aug 6, 2024

OPT-176 Convert: Unit test convert() function in the L2StandardBridge

0xDiscotech
0xDiscotech reviewed Aug 8, 2024
View reviewed changes
packages/contracts-bedrock/test/L2/L2StandardBridgeInterop.t.sol
import { IERC165 } from "@openzeppelin/contracts/utils/introspection/IERC165.sol";
import { IOptimismMintableERC20 } from "src/universal/IOptimismMintableERC20.sol";

// TODO: Replace Predeploys.OPTIMISM_SUPERCHAIN_ERC20_FACTORY with optimismSuperchainERC20Factory
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This TODO is for the future, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, until we have the superchain factory implementation

0xDiscotech
0xDiscotech reviewed Aug 8, 2024
View reviewed changes
Copy link

@0xDiscotech 0xDiscotech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job so far sir!
Left some comments on L2StandardBridgeInterop_LegacyToSuper_Test that also applies for the L2StandardBridgeInterop_SuperToLegacy_Test contract test!

packages/contracts-bedrock/test/L2/L2StandardBridgeInterop.t.sol Outdated Show resolved Hide resolved
packages/contracts-bedrock/test/L2/L2StandardBridgeInterop.t.sol Outdated Show resolved Hide resolved
packages/contracts-bedrock/test/L2/L2StandardBridgeInterop.t.sol Show resolved Hide resolved
packages/contracts-bedrock/test/L2/L2StandardBridgeInterop.t.sol Show resolved Hide resolved
packages/contracts-bedrock/test/L2/L2StandardBridgeInterop.t.sol Show resolved Hide resolved
packages/contracts-bedrock/test/L2/L2StandardBridgeInterop.t.sol Show resolved Hide resolved
@agusduha agusduha merged commit de677a2 into sc/liquidity-migration Aug 8, 2024
3 checks passed
@agusduha agusduha deleted the test/standard-bridge-interop-tests branch August 8, 2024 20:23
agusduha added a commit that referenced this pull request Aug 22, 2024
@agusduha
feat: liquidity migration (ethereum-optimism#11479)
3ad1bb3 
* feat: add L2 standrad bridge interop contract

* test: add L2 standard bridge interop unit tests (#13)

* test: add L2 standard bridge interop unit tests

* fix: add tests natspec

* fix: unit tests fixes

* fix: super to legacy tests failing

* fix: mock and expect mint and burn

* fix: add generic factory interface (#14)

* test: add L2 standard bridge interop unit tests

* fix: add tests natspec

* fix: add generic factory interface

* feat: modify OptimismMintableERC20Factory for convert (#17)

* test: add L2 standard bridge interop unit tests

* fix: add tests natspec

* fix: add generic factory interface

* feat: modify OptimismMintableERC20Factory for convert

* fix: use only a public function for create3

* feat: rollback interop factory, modify legacy one

* fix: delete local token return variable

* fix: PR fixes

* test: fix address assuming

* test: fix view warning

* fix: snapshots

* test: small fixes
0xng pushed a commit that referenced this pull request Sep 10, 2024
@agusduha @0xng
test: add L2 standard bridge interop unit tests (#13)
ba8a862 
* test: add L2 standard bridge interop unit tests

* fix: add tests natspec

* fix: unit tests fixes

* fix: super to legacy tests failing

* fix: mock and expect mint and burn
0xng pushed a commit that referenced this pull request Sep 11, 2024
@agusduha @0xng
test: add L2 standard bridge interop unit tests (#13)
990af3c 
* test: add L2 standard bridge interop unit tests

* fix: add tests natspec

* fix: unit tests fixes

* fix: super to legacy tests failing

* fix: mock and expect mint and burn
0xng pushed a commit that referenced this pull request Sep 11, 2024
@agusduha @0xng
test: add L2 standard bridge interop unit tests (#13)
879a31c 
* test: add L2 standard bridge interop unit tests

* fix: add tests natspec

* fix: unit tests fixes

* fix: super to legacy tests failing

* fix: mock and expect mint and burn
0xng pushed a commit that referenced this pull request Sep 12, 2024
@agusduha @0xng
test: add L2 standard bridge interop unit tests (#13)
2b28469 
* test: add L2 standard bridge interop unit tests

* fix: add tests natspec

* fix: unit tests fixes

* fix: super to legacy tests failing

* fix: mock and expect mint and burn
0xng added a commit that referenced this pull request Sep 12, 2024
@agusduha @0xng
@0xParticle @gotzenx @0xDiscotech
feat: introduce OptimismSuperchainERC20Factory (ethereum-optimism#11617)
232c54d 
* test: add L2 standard bridge interop unit tests (#13)

* test: add L2 standard bridge interop unit tests

* fix: add tests natspec

* fix: unit tests fixes

* fix: super to legacy tests failing

* fix: mock and expect mint and burn

* fix: add generic factory interface (#14)

* test: add L2 standard bridge interop unit tests

* fix: add tests natspec

* fix: add generic factory interface

* feat: modify OptimismMintableERC20Factory for convert (#17)

* test: add L2 standard bridge interop unit tests

* fix: add tests natspec

* fix: add generic factory interface

* feat: modify OptimismMintableERC20Factory for convert

* fix: use only a public function for create3

* feat: rollback interop factory, modify legacy one

* fix: delete local token return variable

* fix: PR fixes

* feat: add superchain erc20 factory implementation (#23)

* feat: add superchain erc20 factory implementation

* fix: remove createX comments

* test: add superchain erc20 factory tests (#25)

* test: add superchain erc20 factory tests

* test: add erc20 asserts

* test: fix expect emit

* fix: remove comments

* feat: add constructor to superchain ERC20 beacon (#34)

* test: remove factory predeploy etch

----------

Co-authored-by: 0xng <[email protected]>
Co-authored-by: 0xParticle <[email protected]>
Co-authored-by: gotzenx <[email protected]>

* fix: set an arbitrary address for superchain erc20 impl

* fix: deploy a proxy for the beacon on genesis (#45)


---------

Co-authored-by: 0xng <[email protected]>

* fix: conflicts and imports

* fix: interfaces

* chore: add .testdata

* fix: adding back .testdata to gitignore

* fix: new conflicts from ci improvements

---------

Co-authored-by: 0xng <[email protected]>
Co-authored-by: 0xParticle <[email protected]>
Co-authored-by: gotzenx <[email protected]>
Co-authored-by: Disco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xDiscotech 0xDiscotech 0xDiscotech approved these changes

@0xng 0xng Awaiting requested review from 0xng

Assignees

@agusduha agusduha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agusduha @0xDiscotech