Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: callbacks #153

Closed
wants to merge 20 commits into from
Closed

feat: callbacks #153

wants to merge 20 commits into from

Conversation

0xiamflux
Copy link

@0xiamflux 0xiamflux commented Dec 13, 2024

Callbacks PoC

This draft showcases a complete callback flow where a call originates on the origin chain, triggers execution on a destination chain, and then returns the result to the origin chain, where it is handled with custom logic.

The flow is as follows:
image

Possible Next Steps

  • Having a dedicated library to abstract functionality and facilitate the interaction would be a valuable addition to the ecosystem.

Possible Future Improvements

  • Flexible Callback Contexts: Introducing a more complex data structure to support features like expiration times or additional metadata.
  • Robust Error Handling: Supporting logic to handle both successful and failed callbacks.

@0xiamflux 0xiamflux changed the title Feat/callbacks WIP: Feat/callbacks Dec 13, 2024
@0xiamflux 0xiamflux changed the base branch from develop to sc-feat/return-data-l2tol2relay December 13, 2024 23:51
@0xiamflux 0xiamflux changed the title WIP: Feat/callbacks feat/callbacks Dec 13, 2024
@0xiamflux 0xiamflux changed the title feat/callbacks feat: callbacks Dec 13, 2024
@0xDiscotech 0xDiscotech changed the base branch from sc-feat/return-data-l2tol2relay to refactor/entrypoint-params-order December 17, 2024 15:59
@0xDiscotech 0xDiscotech changed the base branch from refactor/entrypoint-params-order to develop December 17, 2024 15:59
@0xDiscotech
Copy link

0xDiscotech commented Dec 17, 2024

Only focus on Callbacks and Callbacks.t.sol files. The other diff won't be a diff anymore once the entrypoints branch is merged on the OP repo.
Will merge with develop by then to solve any possible conflict or any other difference

@0xDiscotech 0xDiscotech changed the base branch from develop to sc-feat/entrypoints December 17, 2024 18:35
@0xDiscotech 0xDiscotech dismissed skeletor-spaceman’s stale review December 17, 2024 18:35

The base branch was changed.

@0xDiscotech 0xDiscotech changed the base branch from sc-feat/entrypoints to sc-feat/poc-callbacks December 17, 2024 18:40
@0xDiscotech 0xDiscotech marked this pull request as ready for review December 17, 2024 19:06
hexshire
hexshire previously approved these changes Dec 17, 2024
@0xDiscotech 0xDiscotech changed the base branch from sc-feat/poc-callbacks to sc-feat/entrypoints December 18, 2024 02:33
@0xDiscotech 0xDiscotech dismissed stale reviews from hexshire and skeletor-spaceman December 18, 2024 02:33

The base branch was changed.

@0xDiscotech
Copy link

Closed in favor of a cleaner PR #162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants