forked from ethereum-optimism/optimism
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: callbacks #153
Closed
Closed
feat: callbacks #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: update interface and run scripts
0xiamflux
changed the base branch from
develop
to
sc-feat/return-data-l2tol2relay
December 13, 2024 23:51
skeletor-spaceman
requested changes
Dec 13, 2024
skeletor-spaceman
previously approved these changes
Dec 14, 2024
skeletor-spaceman
previously approved these changes
Dec 17, 2024
0xDiscotech
changed the base branch from
sc-feat/return-data-l2tol2relay
to
refactor/entrypoint-params-order
December 17, 2024 15:59
0xDiscotech
changed the base branch from
refactor/entrypoint-params-order
to
develop
December 17, 2024 15:59
packages/contracts-bedrock/src/L2/L2ToL2CrossDomainMessenger.sol
Outdated
Show resolved
Hide resolved
Only focus on |
0xDiscotech
dismissed
skeletor-spaceman’s stale review
December 17, 2024 18:35
The base branch was changed.
0xDiscotech
changed the base branch from
sc-feat/entrypoints
to
sc-feat/poc-callbacks
December 17, 2024 18:40
hexshire
reviewed
Dec 17, 2024
skeletor-spaceman
previously approved these changes
Dec 17, 2024
hexshire
previously approved these changes
Dec 17, 2024
0xDiscotech
changed the base branch from
sc-feat/poc-callbacks
to
sc-feat/entrypoints
December 18, 2024 02:33
0xDiscotech
dismissed stale reviews from hexshire and skeletor-spaceman
December 18, 2024 02:33
The base branch was changed.
Closed in favor of a cleaner PR #162 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callbacks PoC
This draft showcases a complete callback flow where a call originates on the origin chain, triggers execution on a destination chain, and then returns the result to the origin chain, where it is handled with custom logic.
The flow is as follows:
Possible Next Steps
Possible Future Improvements