fix: merge with dev · defi-wonderland/prophet-modules@e203b92

Triggered via push November 6, 2024 05:01

ashitakah

Status Failure

Total duration 1m 31s

Artifacts –

ci.yml

on: push

Matrix: Run Linters

3 errors and 8 warnings

Process completed with exit code 1.

Run Linters (16.x): solidity/contracts/modules/accessControl/PermitAccessModule.sol#L52

Missing named parameters. Max unnamed parameters value is 4

Process completed with exit code 1.

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Run Linters (16.x): solidity/test/mocks/MockAtomicArbitrator.sol#L21

Variable "_accessControl" is unused

Run Linters (16.x): solidity/test/unit/modules/accessControl/PermitAccessModule.t.sol#L8

imported name IModule is not used

Run Linters (16.x): solidity/test/unit/modules/accessControl/PermitAccessModule.t.sol#L10

imported name IERC20 is not used

Run Linters (16.x): solidity/test/unit/modules/resolution/PrivateERC20ResolutionModule.t.sol#L46

The order of data in contract BaseTest should be: Constants, Immutable variables, State Variables

Run Linters (16.x): solidity/contracts/modules/accessControl/PermitAccessModule.sol#L4

imported name IModule is not used

Run Linters (16.x): solidity/contracts/modules/resolution/BondEscalationResolutionModule.sol#L6

imported name IERC20 is not used