Skip to content

Commit

Permalink
chore: lint
Browse files Browse the repository at this point in the history
  • Loading branch information
xorsal committed Oct 31, 2024
1 parent 618cc36 commit 28f44e9
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 9 deletions.
1 change: 0 additions & 1 deletion solidity/test/integration/RequestCreation.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,6 @@ contract Integration_RequestCreation is IntegrationBase {

vm.startPrank(requester);

// review: should we specify the evm error?
// Check: reverts with `EVM error`?
vm.expectRevert();
oracle.createRequest(mockRequest, _ipfsHash, _createAccessControl());
Expand Down
6 changes: 4 additions & 2 deletions solidity/test/unit/modules/dispute/BondEscalationModule.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,15 @@ import {
BondEscalationModule, IBondEscalationModule
} from '../../../../contracts/modules/dispute/BondEscalationModule.sol';

import '../../../../contracts/utils/Typehash.sol';
import {
_PLEDGE_AGAINST_DISPUTE_TYPEHASH, _PLEDGE_FOR_DISPUTE_TYPEHASH
} from '../../../../contracts/utils/Typehash.sol';
import {IAccountingExtension} from '../../../../interfaces/extensions/IAccountingExtension.sol';
import {IBondEscalationAccounting} from '../../../../interfaces/extensions/IBondEscalationAccounting.sol';

/**
* @dev Harness to set an entry in the requestData mapping, without triggering setup request hooks
*/

contract ForTest_BondEscalationModule is BondEscalationModule {
constructor(IOracle _oracle) BondEscalationModule(_oracle) {}

Expand Down
8 changes: 2 additions & 6 deletions solidity/test/unit/modules/resolution/ArbitratorModule.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,7 @@ contract ArbitratorModule_Unit_StartResolution is BaseTest {
_mockAndExpect(
_arbitrator,
abi.encodeCall(
arbitrator.resolve,
// review
(mockRequest, mockResponse, mockDispute, _createAccessControl(address(arbitratorModule)))
arbitrator.resolve, (mockRequest, mockResponse, mockDispute, _createAccessControl(address(arbitratorModule)))
),
abi.encode(bytes(''))
);
Expand All @@ -143,9 +141,7 @@ contract ArbitratorModule_Unit_StartResolution is BaseTest {
_mockAndExpect(
_arbitrator,
abi.encodeCall(
arbitrator.resolve,
// review
(mockRequest, mockResponse, mockDispute, _createAccessControl(address(arbitratorModule)))
arbitrator.resolve, (mockRequest, mockResponse, mockDispute, _createAccessControl(address(arbitratorModule)))
),
abi.encode(bytes(''))
);
Expand Down

0 comments on commit 28f44e9

Please sign in to comment.