Skip to content

Commit

Permalink
chore: remove commented code
Browse files Browse the repository at this point in the history
  • Loading branch information
xorsal committed Nov 27, 2024
1 parent d9bee52 commit 2b4f309
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 10 deletions.
5 changes: 0 additions & 5 deletions solidity/test/integration/AccountingExtension.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ contract Integration_AccountingExtension is IntegrationBase {
* @notice Depositing ERC20 should update the virtual balance and the token contract balance
*/
function test_depositERC20() public {
// uint256 _initialBalance = 1 ether;
uint256 _depositAmount = 1 ether;

vm.assume(_initialBalance >= _depositAmount);
Expand Down Expand Up @@ -57,7 +56,6 @@ contract Integration_AccountingExtension is IntegrationBase {
* @notice Withdrawing ERC20 should update the virtual balance and the token contract balance
*/
function test_withdrawERC20() public {
// uint256 _initialBalance = 1 ether;
uint256 _depositAmount = 1 ether;
uint256 _withdrawAmount = 0.5 ether;

Expand All @@ -78,7 +76,6 @@ contract Integration_AccountingExtension is IntegrationBase {
* @notice Withdrawing more than the user's virtual balance should revert
*/
function test_withdrawERC20_insufficientFunds() public {
// uint256 _initialBalance = 1 ether;
uint256 _depositAmount = 1 ether;
uint256 _withdrawAmount = 2 ether;
vm.assume(_withdrawAmount > _depositAmount);
Expand All @@ -94,7 +91,6 @@ contract Integration_AccountingExtension is IntegrationBase {
* @notice Withdrawing more WETH than was deposited by the user should revert
*/
function test_withdrawETH_insufficientFunds() public {
// uint256 _initialBalance = 1 ether;
uint256 _depositAmount = 1 ether;
uint256 _withdrawAmount = 2 ether;
vm.assume(_withdrawAmount > _depositAmount);
Expand All @@ -110,7 +106,6 @@ contract Integration_AccountingExtension is IntegrationBase {
* @notice Withdrawing the bonded funds should revert
*/
function test_withdrawBondedFunds() public {
// uint256 _initialBalance = 1 ether;
uint256 _bondAmount = 1 ether;
vm.assume(_bondAmount > 0);
_deposit(_accountingExtension, user, usdc, _bondAmount, _initialBalance);
Expand Down
1 change: 0 additions & 1 deletion solidity/test/integration/Finalization.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ contract Integration_Finalization is IntegrationBase {
*/
function test_revertFinalizeInDisputeWindow() public {
uint256 _timestamp = block.timestamp + _expectedDeadline - _baseDisputeWindow - 1;
// _timestamp = bound(_timestamp, block.timestamp, block.timestamp + _expectedDeadline - _baseDisputeWindow - 1);

_createRequest();
_proposeResponse();
Expand Down
4 changes: 0 additions & 4 deletions solidity/test/integration/ResponseProposal.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ contract Integration_ResponseProposal is IntegrationBase {
uint256 _secondsAfter = 365 days;
bytes memory _responseBytes = abi.encode('any-response');

// _secondsAfter = bound(_secondsAfter, 1, type(uint248).max);

// Warp to timestamp after deadline
vm.warp(block.timestamp + _expectedDeadline + _secondsAfter);

Expand All @@ -78,8 +76,6 @@ contract Integration_ResponseProposal is IntegrationBase {
vm.prank(proposer);
oracle.proposeResponse(mockRequest, mockResponse, _createAccessControl());

// review: When this request is _answered_?

mockResponse.response = abi.encode('second response');

// Check: does revert if already responded?
Expand Down

0 comments on commit 2b4f309

Please sign in to comment.