chore: remove addressed todos

by _addressed_ I mean either in this branch or by creating a task to track it :)
defi-wonderland · Nov 12, 2024 · b863c5e · b863c5e
1 parent a57e89d
commit b863c5e
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 6 deletions.
diff --git a/solidity/contracts/modules/access/ModuleAccessController.sol b/solidity/contracts/modules/access/ModuleAccessController.sol
@@ -40,7 +40,6 @@ abstract contract ModuleAccessController is IModuleAccessController, CommonAcces
     if (msg.sender != _accessControl.user && !ORACLE.isAccessModuleApproved(_accessControl.user, _accessModule)) {
       revert ModuleAccessController_AccessModuleNotApproved();
     }
-    // todo: probably a change name is required here, something like `_ensureAccess`?
     _hasAccess(_accessModule, _typehash, _params, _accessControl);
     _;
   }

diff --git a/solidity/test/integration/BondEscalation.t.sol b/solidity/test/integration/BondEscalation.t.sol
@@ -348,7 +348,6 @@ contract Integration_BondEscalation is IntegrationBase {
     _bondEscalationModule.pledgeForDispute(mockRequest, mockDispute, _createAccessControl(_secondDisputer));
 
     // Step 7: They go into the dispute resolution module
-    // review: we could use a global address `_anyone`
     address _escalator = makeAddr('escalator');
     vm.prank(_escalator);
     oracle.escalateDispute(mockRequest, mockResponse, mockDispute, _createAccessControl(_escalator));
@@ -428,7 +427,6 @@ contract Integration_BondEscalation is IntegrationBase {
 
     vm.warp(block.timestamp + _bondEscalationDeadline + 1);
 
-    // todo: use `_anyone`
     vm.prank(_escalator);
     oracle.escalateDispute(mockRequest, mockResponse, mockDispute, _createAccessControl(_escalator));
     vm.prank(_resolver);

diff --git a/solidity/test/mocks/MockAtomicArbitrator.sol b/solidity/test/mocks/MockAtomicArbitrator.sol
@@ -20,7 +20,6 @@ contract MockAtomicArbitrator is IArbitrator {
   ) external returns (bytes memory _result) {
     _result = new bytes(0);
     answer = IOracle.DisputeStatus.Won;
-    // review: really not sure about this change
     oracle.resolveDispute(_request, _response, _dispute, IAccessController.AccessControl(address(this), bytes('')));
   }
 

diff --git a/solidity/test/unit/modules/dispute/BondEscalationModule.t.sol b/solidity/test/unit/modules/dispute/BondEscalationModule.t.sol
@@ -1684,7 +1684,6 @@ contract BondEscalationModule_Unit_AccessControl is BaseTest {
 
     _setBondEscalation(_requestId, _numForPledgers, _numAgainstPledgers);
 
-    // todo: extract to helper when we add tests for the other access controlled functions
     _mockAndExpect(
       address(oracle),
       abi.encodeCall(IOracleAccessController.isAccessModuleApproved, (_user, _accessModule)),

diff --git a/solidity/test/unit/modules/response/BondedResponseModule.t.sol b/solidity/test/unit/modules/response/BondedResponseModule.t.sol
@@ -646,7 +646,6 @@ contract BondedResponseModule_Unit_ReleaseUnutilizedResponse is BaseTest {
         vm.expectRevert(IBondedResponseModule.BondedResponseModule_InvalidReleaseParameters.selector);
       }
 
-      // todo: use `_anyone`
       address _notTheProposer = makeAddr('not-the-proposer');
       vm.prank(_notTheProposer);
       bondedResponseModule.releaseUnutilizedResponse(mockRequest, _response);