test: request modules integration tests #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashitakah
requested changes
Oct 13, 2024
| _target = new MockCallee(); | ||
| } | ||
|
|
||
| function test_createRequest_finalizeEmptyResponse(bytes4 _selector, bytes calldata _data) public { |
There was a problem hiding this comment.
From line 30 to 47 could be move it to the setup
| _target = new MockCallee(); | ||
| } | ||
|
|
||
| function test_createRequest_finalizeEmptyResponse(bytes4 _selector, bytes calldata _data) public { |
There was a problem hiding this comment.
also as the previous pr, if I were me I would delete the params and create a selector and a data for the test
| import {MockCallee} from '../mocks/MockCallee.sol'; | ||
| import './IntegrationBase.sol'; | ||
|
|
||
| contract Integration_ContractCallRequest is IntegrationBase { |
There was a problem hiding this comment.
Also probably when you finalize the request , in the oracle the status will change, would be awesome to have asserts for this status, and expectCall to check that pay al release have been called with the correct params.
| import {IHttpRequestModule} from '../../contracts/modules/request/HttpRequestModule.sol'; | ||
| import './IntegrationBase.sol'; | ||
|
|
||
| contract Integration_HttpRequest is IntegrationBase { |
There was a problem hiding this comment.
similar comments that I put in the other test
- move common logic to internal function - avoid using fuzzing in integration tests - use startPrank, get rid of repeated lines
0xShaito
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes OPO-658