feat: bond escalation tests #67
Conversation
… feat/bond-escalation-tests
| vm.startPrank(disputer); | ||
|
|
||
| // Pledge revert if break tie during tying buffer | ||
| _mineBlocks(_blocksDeadline + 1); |
There was a problem hiding this comment.
I'd use vm.warp instead of _mineBlocks
_mineBlocks also updates the timestamp but I think it's clearer to handle it directly here.
| _bondEscalationModule.pledgeForDispute(mockRequest, mockDispute); | ||
|
|
||
| // Roll back the blocks because we need to simulate the custom error "break tie during tying buffer" and "bond escalation over" | ||
| vm.warp(block.timestamp - (_blocksDeadline + _tyingBuffer + 1) * BLOCK_TIME); |
There was a problem hiding this comment.
I'd drop all code related to blocks deadline since we already ensure the modules only deal with relative timestamps or time windows.
| vm.expectRevert(IBondEscalationModule.BondEscalationModule_CannotBreakTieDuringTyingBuffer.selector); | ||
| _bondEscalationModule.pledgeForDispute(mockRequest, mockDispute); | ||
|
|
||
| _mineBlocks(_tyingBuffer); |
| _bondEscalationModule.settleBondEscalation(mockRequest, mockResponse, mockDispute); | ||
|
|
||
| // Mine blocks to pass the escalation deadline | ||
| _mineBlocks(_expectedDeadline + 1); |
There was a problem hiding this comment.
but consider that _expectedDeadline is now (after #64 was merged) the number of seconds after the creation of the request at which the ResponseModule stop accepting new responses.
| vm.expectRevert(IBondEscalationModule.BondEscalationModule_BondEscalationOver.selector); | ||
| _bondEscalationModule.pledgeForDispute(mockRequest, mockDispute); | ||
|
|
||
| // Roll back the blocks because we need to simulate the custom error "break tie during tying buffer" and "bond escalation over" |
| _bondEscalationModule.pledgeForDispute(mockRequest, mockDispute); | ||
|
|
||
| // Mine blocks to pass the escalation deadline | ||
| vm.warp(block.timestamp + _disputeCreatedAt + _blocksDeadline + 1); |
| oracle.escalateDispute(mockRequest, mockResponse, mockDispute); | ||
|
|
||
| // Roll back the blocks because we need to simulate the custom error "not escalatable" | ||
| vm.warp(block.timestamp - (_disputeCreatedAt + _blocksDeadline + 1)); |
There was a problem hiding this comment.
instead you could rollback the timestamp doing vm.warp(_disputeCreatedAt)
There was a problem hiding this comment.
Its true, however as I know that this logic is more complex I decided to do like this in order to clarify that we are doing something "triky" and is not the natural flow
| @@ -71,6 +71,9 @@ contract Integration_EscalateDispute is IntegrationBase { | |||
| _disputeId = oracle.disputeResponse(mockRequest, mockResponse, mockDispute); | |||
| vm.stopPrank(); | |||
|
|
|||
| // Simulate the time passing | |||
| vm.roll(1 days); | |||
There was a problem hiding this comment.
Just noticed this one. It's confusing to use vm.roll with a time constant
… feat/bond-escalation-tests
🤖 Linear
Closes OPO-654