Skip to content

Commit

Permalink
docs: add warning
Browse files Browse the repository at this point in the history
  • Loading branch information
excaliborr committed Nov 27, 2023
1 parent c29b80a commit b5bb0dc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ The project is a PoC implementation and should be treated with caution. Bellow w
- `UpdateStorageMirrorGuard` for the PoC this guard is calling the `GuardCallbackModule` in every call. A possible improvement would be to decode the txData, on the guard `checkTransaction` pre-execute hook, and filter against certain function signatures that change the settings of a Safe to accurately catch the change.
- `NeedsUpdateGuard` this guard on the non-home chain can brick the user's safe, since it will block every tx, if their security settings expire. Also it's worth mentioning that before using the guard the safe owner must verify at least 1 set of settings using the VerifierModule in order for the guard to have a point of reference for the latest verified update.
- `VerifierModule` is executing a safeTx after the verification and update of their settings. This safeTx can become invalid since the signatures passed were created before the change of the settings, in this case the user(s) will need to re-sign the tx manually outside of the UI. A possible improvement would be to have a custom safe app that let's you sign even if you are not a "current owner" but are a "potential future owner" of the "soon-to-be-updated" settings
- `VerifierModule` makes the assumption that the address of the safe is the same on both the home chain, and non-home chain. The current implementation will not work if these addresses are different

## Contributors

Expand Down
2 changes: 1 addition & 1 deletion solidity/contracts/VerifierModule.sol
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ contract VerifierModule is IVerifierModule {

/**
* @notice Verifies the new settings that are incoming against a storage proof from the StorageMirror on the home chain
*
* @dev This function makes the assumption that the safe address is the same on both the home and non-home chain as it will break if they are different
* @param _safe The address of the safe that has new settings
* @param _proposedSettings The new settings that are being proposed
* @param _storageMirrorStorageProof The storage proof of the StorageMirror contract on the home chain
Expand Down

0 comments on commit b5bb0dc

Please sign in to comment.