-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: storage mirror root registry #10
Conversation
SAF-30 StorageMirrorRootRegistry
This contract should accept and store storageRoots of the StorageMirror contract in L1. SAF-32 StorageMirrorRootRegistry Contract
|
VERIFIER_MODULE.extractStorageMirrorStorageRoot(_blockHeader, _accountProof); | ||
|
||
latestVerifiedStorageMirrorStorageRoot = _latestVerifiedStorageMirrorStorageRoot; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After thinking more about it, i thinks its good UX to save the block number as well so a new searcher who wasnt previously subscribed to the events knows what the latest verified block was easily, it makes the operation slightly more expensive but i think its good UX for searchers,everything else looks good.
…eat/storage-mirror-root-registry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
🤖 Linear
Closes SAF-30, SAF-31, SAF-32