Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: periphery function to do the verification flow in one transaction #11

Merged
merged 16 commits into from
Nov 23, 2023
Merged

feat: periphery function to do the verification flow in one transaction #11

merged 16 commits into from
Nov 23, 2023

Conversation

excaliborr
Copy link
Contributor

🤖 Linear

Closes SAF-37

Needs to be merged after PR #9

@linear Linear
Copy link

linear bot commented Nov 20, 2023

SAF-37 Add 1 way verification for the Verifier Module

  • Has a function verifyStorageRootAndVerifyUpdate(safe, proposedSettings, storageProof, accountProof) which is a periphery function that does the flow of verifying storage root and the update in one transaction.
  • unit tests

@excaliborr excaliborr changed the title feat: periphery function to do the whole flow in one transaction feat: periphery function to do the verification flow in one transaction Nov 20, 2023
@0xOneTony 0xOneTony changed the base branch from dev to feat/verifier November 21, 2023 09:31
0xOneTony
0xOneTony previously approved these changes Nov 21, 2023
View reviewed changes
Base automatically changed from feat/verifier to dev November 21, 2023 14:57
@0xOneTony 0xOneTony dismissed their stale review November 21, 2023 14:57

The base branch was changed.

0xOneTony
0xOneTony reviewed Nov 23, 2023
View reviewed changes
Copy link
Member

@0xOneTony 0xOneTony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but pull latest dev because I see some changes in yarn.lock

@excaliborr excaliborr merged commit bf92614 into dev Nov 23, 2023
5 checks passed
@excaliborr excaliborr deleted the feat/periphery-one-txn branch November 23, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xOneTony 0xOneTony 0xOneTony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@excaliborr @0xOneTony