feat: e2e base #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SAF-24 Create Base for E2E test
We need to create a common base contract to have as a setup for our e2e tests |
excaliborr
reviewed
Nov 15, 2023
solidity/test/TestConstants.sol
Outdated
|
|
||
| contract TestConstants { | ||
| address public constant GNOSIS_SAFE_PROXY_FACTORY = 0xa6B71E26C5e0845f74c812102Ca7114b6a896AB2; | ||
| address public constant GNOSIS_SAFE_SINGLETON = 0x3E5c63644E683549055b9Be8653de26E0B4CD36E; |
There was a problem hiding this comment.
This looks like the L2 singleton address the L1 one is the address below
0xd9Db270c1B5E3Bd161E8c8503c55cEABeE709552
excaliborr
reviewed
Nov 15, 2023
solidity/test/e2e/Common.sol
Outdated
| function setUp() public { | ||
| StorageMirror public storageMirror; | ||
| UpdateStorageMirrorGuard public updateStorageMirrorGuard; | ||
| SafeProxy public safe; |
There was a problem hiding this comment.
I would save the safe as an ISafe and cast the proxy into it when you deploy it, as the proxy doesnt have any functions and only uses fallbacks, will be annoying to test with it without this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes SAF-24