Skip to content

Commit

Permalink
style: reorder functions declarations
Browse files Browse the repository at this point in the history
  • Loading branch information
hexshire authored Apr 5, 2024
1 parent 4af7fa8 commit 06de827
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions src/interfaces/IGreeter.sol
Original file line number Diff line number Diff line change
Expand Up @@ -58,18 +58,17 @@ interface IGreeter {
/*///////////////////////////////////////////////////////////////
LOGIC
//////////////////////////////////////////////////////////////*/
/**
* @notice Sets a new greeting
* @dev Only callable by the owner
* @param _newGreeting The new greeting to be set
*/
function setGreeting(string memory _newGreeting) external;

Check warning on line 66 in src/interfaces/IGreeter.sol

View workflow job for this annotation

GitHub Actions / Lint Commit Messages

Function order is incorrect, external function can not go after external view function (line 56)

/**
* @notice Greets the caller
* @return _greeting The greeting
* @return _balance Current token balance of the caller
*/
function greet() external view returns (string memory _greeting, uint256 _balance);

/**
* @notice Sets a new greeting
* @dev Only callable by the owner
* @param _newGreeting The new greeting to be set
*/
function setGreeting(string memory _newGreeting) external;
}

0 comments on commit 06de827

Please sign in to comment.