feat: add check proposer (#28)

defi-wonderland · Jul 15, 2024 · 77e9130 · 77e9130
1 parent 1e39da6
commit 77e9130
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/solidity/contracts/Oracle.sol b/solidity/contracts/Oracle.sol
@@ -130,11 +130,11 @@ contract Oracle is IOracle {
   ) external returns (bytes32 _disputeId) {
     _disputeId = _validateDispute(_request, _response, _dispute);
 
-    if (_dispute.disputer != msg.sender) {
+    if (_dispute.proposer != _response.proposer) {
       revert Oracle_InvalidDisputeBody();
     }
 
-    if (createdAt[_dispute.requestId] == 0) {
+    if (_dispute.disputer != msg.sender || createdAt[_dispute.requestId] == 0) {
       revert Oracle_InvalidDisputeBody();
     }
 

diff --git a/solidity/test/unit/Oracle.t.sol b/solidity/test/unit/Oracle.t.sol
@@ -536,6 +536,23 @@ contract Oracle_Unit_DisputeResponse is BaseTest {
     }
   }
 
+  /**
+   * @notice Reverts if the dispute proposer and response proposer are not same
+   */
+  function test_disputeResponse_revertIfProposerIsNotValid(address _otherProposer) public {
+    vm.assume(_otherProposer != proposer);
+    oracle.mock_setCreatedAt(_getId(mockRequest), 0);
+
+    // Check: revert?
+    vm.expectRevert(IOracle.Oracle_InvalidDisputeBody.selector);
+
+    mockDispute.proposer = _otherProposer;
+
+    // Test: try to dispute the response
+    vm.prank(disputer);
+    oracle.disputeResponse(mockRequest, mockResponse, mockDispute);
+  }
+
   /**
    * @notice Reverts if the request doesn't exist
    */