feat: add natspec-smells #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gas1cent
reviewed
Jan 18, 2024
| @@ -0,0 +1,9 @@ | |||
| /** | |||
| * List of supported options: https://github.com/defi-wonderland/natspec-smells?tab=readme-ov-file#options | |||
There was a problem hiding this comment.
Observation: constructorNatspec option is by default set to false. 🤔
There was a problem hiding this comment.
@dristpunk let's see if most projects you have been testing the tool with have constructor natspec. I argue it's not that popular and hence the setting should be set to false even in our own projects.
There was a problem hiding this comment.
we decided to leave it as it is for now
0xJabberwock
approved these changes
Jan 30, 2024
gas1cent
approved these changes
Jan 30, 2024
0xRaccoon
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes BES-236