Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gitignore echidna corpus #72

Merged
merged 5 commits into from
Jul 5, 2024
Merged

feat: gitignore echidna corpus #72

merged 5 commits into from
Jul 5, 2024

Conversation

gas1cent
Copy link
Member

@gas1cent gas1cent commented Jul 1, 2024

No description provided.

@gas1cent gas1cent requested a review from simon-something July 1, 2024 06:40
@gas1cent gas1cent self-assigned this Jul 1, 2024
@simon-something
Copy link
Member

hmm, not 100% certain we should do this. Reusing corpus is a huge benefit of Echidna, as every time you run it, it will start by replaying the previously "interesting" sequence of transaction. On the other hand, I get the issue of ever growing corpus dir in a repo...

We need a public good to compress/uncompress them (and only keep the latest coverage report)

simon-something
simon-something previously approved these changes Jul 1, 2024
Copy link
Member

@simon-something simon-something left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do it for now but let's try to find a better solution in the long run

Copy link
Member

@wei3erHase wei3erHase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i support keeping the corpus out of the repo bc:

  • would add a LOT of changes each time
  • would mean all devs and processes share the same corpus (instead of each making their own)

@gas1cent gas1cent merged commit 2615e9c into main Jul 5, 2024
7 checks passed
@gas1cent gas1cent deleted the feat/ignore-test-output branch July 5, 2024 14:57
xorsal pushed a commit that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants