feat: improve coverage action #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gas1cent
commented
Jul 1, 2024
•
gas1cent
commented
- Renamed coverage check on main -> coverage check
- Upgraded actions to v4
- Excluded integration tests from the coverage report
wei3erHase
reviewed
Jul 1, 2024
simon-something
previously approved these changes
Jul 1, 2024
0xteddybear
reviewed
Jul 1, 2024
.github/workflows/coverage.yml
Outdated
| @@ -28,7 +29,7 @@ jobs: | |||
|
|
|||
| - name: Run coverage | |||
| shell: bash | |||
| run: forge coverage --report summary --report lcov | |||
| run: forge coverage --report summary --report lcov --match-contract Unit | |||
There was a problem hiding this comment.
- when writing
.treefiles, theUnitpart of the module under test is usually skipped (at least it is on this repo) - then, if testcases are generated with
bulloak scaffold, the contract names won't includeUnit - therefore, those tests won't be run, and we'll have false CI negatives and lack of coverage
I'd pass --match-path test/unit/* instead (remember match path uses globs instead of regex)
0xteddybear
approved these changes
Jul 2, 2024
simon-something
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.