-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: run medusa in CI #86
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xteddybear
force-pushed
the
ci/medusa-gh-action
branch
7 times, most recently
from
October 15, 2024 18:10
78e64c5
to
3f7335d
Compare
gas1cent
reviewed
Oct 15, 2024
0xteddybear
force-pushed
the
ci/medusa-gh-action
branch
from
October 15, 2024 21:45
3f7335d
to
92dd632
Compare
4 tasks
0xteddybear
force-pushed
the
ci/medusa-gh-action
branch
from
October 15, 2024 22:31
92dd632
to
f753b6b
Compare
0xteddybear
changed the title
chore: use medusa instead of echidna and configure gh action for it
chore: run medusa in CI
Oct 15, 2024
0xteddybear
force-pushed
the
ci/medusa-gh-action
branch
2 times, most recently
from
October 16, 2024 16:13
04d1cb1
to
204ccc5
Compare
update: I went for the 'run the entire CI inside a container' option, which proved simple enough if we maintain a fork of the docker image, see 0xteddybear/eth-security-toolbox-ci#1 TODO
|
0xteddybear
force-pushed
the
ci/medusa-gh-action
branch
4 times, most recently
from
October 17, 2024 18:24
825b36e
to
65562a7
Compare
0xteddybear
force-pushed
the
ci/medusa-gh-action
branch
2 times, most recently
from
October 22, 2024 15:18
3f49064
to
54c0819
Compare
0xteddybear
force-pushed
the
ci/medusa-gh-action
branch
2 times, most recently
from
November 28, 2024 15:31
63faf10
to
4dc57f9
Compare
0xteddybear
force-pushed
the
ci/medusa-gh-action
branch
from
December 16, 2024 14:47
4dc57f9
to
7d03a6e
Compare
gas1cent
reviewed
Dec 16, 2024
0xteddybear
force-pushed
the
ci/medusa-gh-action
branch
from
December 17, 2024 22:10
0065d63
to
06f3f28
Compare
gas1cent
previously approved these changes
Dec 20, 2024
note: will update ci image version on monday, after the nightly tagged release |
gas1cent
approved these changes
Dec 24, 2024
0xGorilla
approved these changes
Dec 25, 2024
hexshire
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge after #87
this PR aims to include a short medusa run in CI, to avoid pushing false positives/errors that can be caught within 5min of fuzzing
it's a WIP, and I'm currently torn between 3 approaches:I believe having a docker image all our CI runs in is the way to go, see update belowdocker-based action
this is a derivative of
crytic/echidna-action
, but modified to useeth-security-toolbox
which has mostly up-to-date versions of a typical solidity toolchain, including medusa. with this, we don't have to worry about installing/updating medusa or crytic-compile, but have to (inside the action definition) deal with the mismatch between the github runner assuming everything will be executed as root and the image configuring everything for a normal user namedethsec
pros:
cons:
forge fmt
param, so I had to add afoundryup
in the Dockerfile )running the entire CI inside
eth-security-toolbox
The entire CI workflow would run inside a container that already has most tools in it, so we could do away with most 'setup' steps in workflow definitions.
However, due to the root-vs-nonroot issue outlined above, we would have to either modify most ci steps so they walk around that or maintain a fork/extension of the aforementioned image so it makes everything available to root
pros
cons
create an action to install medusa in the non-containerized gh runner environment
this would be similar to how we install foundry in CI: https://github.com/foundry-rs/foundry-toolchain/
pros:
cons