-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migration to NextJS + materialUI | upgrade wagmi + rainbowkit + viem #7
Conversation
chore: wagmi, rainbowkit, viem updates tests: rainbokit 2.x breaking changes updates fix: injected wallet for empty projectId logic fix: wallets type error - projectid not required rainbowWallet nor walletConnect fix: caret removed fix: group imports chore: update viem and wagmi to latest version (#1) fix: yarn libs error
* chore: nextJS migration | *removed styles due to near future materialUI migration* * test: vitest adapted to nextJS environment, simple testing * fix: test type assertion | build type assertion fixes * fix: removed build info file * fix: added tsconfig.tsbuildinfo to gitignore - false possitive on private keys * fix: removed caret * fix: reinstalled yarn.lock build issues * fix: build issue with node version * fix: update nodejs version NextJS migration nodeJS version issue * fix: Ensure using correct Node.js version in GitHub Actions * fix: nodejs version issue * fix: revert back to nodejs -v 18.7 * fix: resolve "x" type + udpate version 21.4 * fix: remove carets * fix: remove carets * fix: footer/header tags | group imports | sort imports * fix: next.config default * fix: eslintrc remove typeprops rule + default file * fix: remove unused libs and old tests * fix: remove vite and vitest * fix:lint issue * fix: layout children proptype validation * fix: remove test - cypress migration * fix: added cypress and pnpm * fix: remove caret
* refactor: nextJS architecture improvement * fix: materialUI styling as per styled components version * fix: building materialUI Theme bug * fix: remove carets | imports sorting * fix: wallet connect issues + sepolia | mobile view alert * fix: remove use client * chore: misc fixes * chore: update pnpm-lock file --------- Co-authored-by: Ardy <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@turtlemoji what do you think about changing |
I'm ok with pnpm, but I don't know If I like the idea to setup nextjs as default. Not all projects need it. |
@@ -0,0 +1,5 @@ | |||
describe('template spec', () => { | |||
it('passes', () => { | |||
cy.visit('https://example.cypress.io'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change default examples, maybe
@@ -0,0 +1,5 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change or delete examples
router.events.on('routeChangeComplete', handleRouteChange); | ||
|
||
return () => { | ||
router.events.off('routeChangeComplete', handleRouteChange); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recheck for memory leaks / this is working as expected
migration to NextJS + materialUI | upgrade wagmi + rainbowkit + viem
Checklist before requesting a review