Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migration to NextJS + materialUI | upgrade wagmi + rainbowkit + viem #7

Closed
wants to merge 3 commits into from

Conversation

0xtiti
Copy link
Contributor

@0xtiti 0xtiti commented Mar 21, 2024

migration to NextJS + materialUI | upgrade wagmi + rainbowkit + viem

Checklist before requesting a review

  • I have conducted a self-review of my code.
  • If it is a core feature, I have included comprehensive tests.
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one sentence about this update.

0xtiti and others added 3 commits March 15, 2024 10:44
chore: wagmi, rainbowkit, viem updates

tests: rainbokit 2.x breaking changes updates

fix: injected wallet for empty projectId logic

fix: wallets type error - projectid not required rainbowWallet nor walletConnect

fix: caret removed

fix: group imports

chore: update viem and wagmi to latest version (#1)

fix: yarn libs error
* chore: nextJS migration | *removed styles due to near future materialUI migration*

* test: vitest adapted to nextJS environment, simple testing

* fix: test type assertion | build type assertion fixes

* fix: removed build info file

* fix: added tsconfig.tsbuildinfo to gitignore - false possitive on private keys

* fix: removed caret

* fix: reinstalled yarn.lock build issues

* fix: build issue with node version

* fix: update nodejs version

NextJS migration nodeJS version issue

* fix: Ensure using correct Node.js version in GitHub Actions

* fix: nodejs version issue

* fix: revert back to nodejs -v 18.7

* fix: resolve "x" type + udpate version 21.4

* fix: remove carets

* fix: remove carets

* fix: footer/header tags | group imports | sort imports

* fix: next.config default

* fix: eslintrc remove typeprops rule + default file

* fix: remove unused libs and old tests

* fix: remove vite and vitest

* fix:lint issue

* fix: layout children proptype validation

* fix: remove test - cypress migration

* fix: added cypress and pnpm

* fix: remove caret
* refactor: nextJS architecture improvement

* fix: materialUI styling as per styled components version

* fix: building materialUI Theme bug

* fix: remove carets | imports sorting

* fix: wallet connect issues + sepolia | mobile view alert

* fix: remove use client

* chore: misc fixes

* chore: update pnpm-lock file

---------

Co-authored-by: Ardy <[email protected]>
Copy link

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3-react-boilerplate ✅ Ready (Inspect) Visit Preview Mar 21, 2024 1:03pm

@0xtiti 0xtiti requested review from turtlemoji and 0xArdy March 21, 2024 13:14
@0xArdy
Copy link
Member

0xArdy commented Mar 21, 2024

@turtlemoji what do you think about changing yarn to pnpm? We use pnpm in the superchain bridge repo bc yarn was giving problems when building and running the app locally with nextjs

@turtlemoji
Copy link

@turtlemoji what do you think about changing yarn to pnpm? We use pnpm in the superchain bridge repo bc yarn was giving problems when building and running the app locally with nextjs

I'm ok with pnpm, but I don't know If I like the idea to setup nextjs as default. Not all projects need it.

@@ -0,0 +1,5 @@
describe('template spec', () => {
it('passes', () => {
cy.visit('https://example.cypress.io');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change default examples, maybe

@@ -0,0 +1,5 @@
{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change or delete examples

router.events.on('routeChangeComplete', handleRouteChange);

return () => {
router.events.off('routeChangeComplete', handleRouteChange);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recheck for memory leaks / this is working as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants