feat: add BalanceClaimer and contracts update #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
0xRaccoon
requested review from
0xmoebius,
turtlemoji,
agusduha,
0xnigir1 and
nemuiikiryou
Signed-off-by: 0xRaccoon <[email protected]>
0xteddybear
reviewed
Oct 23, 2024
packages/contracts-bedrock/contracts/L1/winddown/BalanceClaimer.sol
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/contracts/L1/winddown/BalanceClaimer.sol
Outdated
Show resolved
Hide resolved
|
|
||
| contract WinddownUpgrade is Script { | ||
| function run() public { | ||
| uint256 _deployerPk = vm.envUint("PRIVATE_KEY_PROXY_ADMIN"); |
There was a problem hiding this comment.
have we considered using keystores like we do in the boilerplate?
There was a problem hiding this comment.
can you provide the reference?, I can check if we can use it
0xteddybear
reviewed
Oct 23, 2024
packages/contracts-bedrock/contracts/L1/winddown/BalanceClaimer.sol
Outdated
Show resolved
Hide resolved
turtlemoji
reviewed
Oct 26, 2024
packages/contracts-bedrock/scripts/winddown-upgrade/WinddownConstants.sol
Outdated
Show resolved
Hide resolved
turtlemoji
reviewed
Oct 26, 2024
packages/contracts-bedrock/scripts/winddown-upgrade/WinddownConstants.sol
Show resolved
Hide resolved
turtlemoji
reviewed
Oct 26, 2024
| @@ -8,6 +8,10 @@ PRIVATE_KEY_DEPLOYER= | |||
| TENDERLY_PROJECT= | |||
There was a problem hiding this comment.
can we check
/packages/contracts-bedrock/README.md ?
Specifically that is mandatory to use foundry version:
foundryup -C da2392e58bb8a7fefeba46b40c4df1afad8ccd22
0xmoebius
reviewed
Oct 28, 2024
packages/contracts-bedrock/contracts/L1/interfaces/winddown/IBalanceClaimer.sol
Outdated
Show resolved
Hide resolved
0xmoebius
reviewed
Oct 28, 2024
packages/contracts-bedrock/contracts/L1/interfaces/winddown/IErc20BalanceWithdrawer.sol
Outdated
Show resolved
Hide resolved
0xmoebius
reviewed
Oct 28, 2024
packages/contracts-bedrock/contracts/L1/interfaces/winddown/IEthBalanceWithdrawer.sol
Outdated
Show resolved
Hide resolved
0xmoebius
reviewed
Oct 28, 2024
packages/contracts-bedrock/contracts/L1/winddown/BalanceClaimer.sol
Outdated
Show resolved
Hide resolved
0xmoebius
reviewed
Oct 28, 2024
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose is to allow users to claim their balances of
ethandERC20tokens with a prior snapshot of their balances.Currently, the assets to be claimed by the users are located in 2 contracts in
mainnet:A snapshot of the users'
ethbalance ofOptimismPortaland snapshot of the users'ERC20balances ofL1StandardBridgewill be taken and the Merkle tree, root, and proofs for users will be generated off-chain.The approach consists of a contract
BalanceClaimerthat contains thebytes32merkle root value, all the Merkle verification logic, and claims methods. To achieve this approach, it is be necessary to updateL1StandardBridgeand theOptimisimPotalcontracts and add the following methods:withdrawErc20Balanceonly called byBalanceClaimercontract after claim verification to send the user token balances.withdrawEthBalanceonly called byBalanceClaimercontract after claim verification to send the userethbalance.The
claimmethod is permissionless and can be called by any address.Wind Down Deploy and upgrade scripts:
Local test:
yarn upgrade-local:winddownProd:
yarn upgrade-prod:winddown