Add UserNotifications Framework for iOS 10+ #90

mrgrauel · 2017-01-20T08:53:45Z

I added a permission for the new notification framework UserNotifications in iOS 10 to request permission with the new api.

add permission UserNotification
add configuration PERMISSION_USERNOTIFICATIONS
add permissionType userNotifications
removed the file private static variable _notification cause it's never read
did not change the requestedNotifications default cause it returns the same information

I tried to keep it in the structure you designed the framework.

mrgrauel · 2017-01-20T09:10:42Z

On my local machine the tests do run. Does anybody has an idea why the checks fail?

mrgrauel · 2017-01-31T06:28:05Z

@delba what's going on?

pasevin · 2017-02-05T01:43:49Z

Any chance this is going to be merged?

delba · 2017-03-05T20:56:48Z

Source/Permission.swift

@@ -98,31 +116,22 @@ open class Permission: NSObject {
        return Permission(type: .notifications(settings))
    }()

-    /// Variable used to retain the notifications permission.
-    fileprivate static var _notifications: Permission?


This variable is used to retain the permission as stated in the comment above.

delba · 2017-03-05T20:57:19Z

Source/Permission.swift

    /// The permission to send notifications.
    open static func notifications(types: UIUserNotificationType, categories: Set<UIUserNotificationCategory>?) -> Permission {
-        let settings   = UIUserNotificationSettings(types: types, categories: categories)
-        let permission = Permission(type: .notifications(settings))
-        _notifications = permission


_notifications is used to retain the permission

delba · 2017-03-05T20:57:31Z

Source/Permission.swift

    }

    /// The permission to send notifications.
    open static func notifications(types: UIUserNotificationType) -> Permission {
        let settings   = UIUserNotificationSettings(types: types, categories: nil)
-        let permission = Permission(type: .notifications(settings))
-        _notifications = permission


Same comment as above

delba · 2017-03-05T20:57:51Z

Source/Permission.swift

    }

    /// The permission to send notifications.
    open static func notifications(categories: Set<UIUserNotificationCategory>?) -> Permission {
        let settings  = UIUserNotificationSettings(types: [.badge, .sound, .alert], categories: categories)
-        let permission = Permission(type: .notifications(settings))
-        _notifications = permission


delba · 2017-03-05T20:59:13Z

Source/Permission.swift

+    /// The permission to send notifications.
+    @available(iOS 10.0, *)
+    open static func userNotifications(options: UNAuthorizationOptions) -> Permission {
+        return Permission(type: .userNotifications(options))


We need to retain the permission with a private var like in the case of notifications (e.g: _userNotifications)

delba · 2017-03-05T21:01:38Z

Source/PermissionType.swift

@@ -21,6 +21,9 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 // SOFTWARE.
 //
+#if PERMISSION_NOTIFICATIONS


Should be PERMISSION_USERNOTIFICATIONS

delba · 2017-03-05T21:04:01Z

Permission.podspec

@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
  s.name         = "Permission"
-  s.version      = "2.0.3"
+  s.version      = "2.1.0"


I prefer to change it just before pushing it (and it's dependent on the git tag)

delba · 2017-03-05T21:04:42Z

Permission.podspec

@@ -64,6 +64,11 @@ Pod::Spec.new do |s|
    no.pod_target_xcconfig = { "SWIFT_ACTIVE_COMPILATION_CONDITIONS"  => "PERMISSION_NOTIFICATIONS" }
  end

+  s.subspec 'UserNotifications' do |no|
+    no.dependency 'Permission/Core'
+    no.pod_target_xcconfig = { "SWIFT_ACTIVE_COMPILATION_CONDITIONS"  => "PERMISSION_USERNOTIFICATIONS" }


Could we rename PERMISSION_USERNOTIFICATIONS to PERMISSION_USER_NOTIFICATIONS for the sake of consistency please?

delba · 2017-03-05T21:08:59Z

Source/PermissionTypes/UserNotifications.swift

+import UserNotifications
+
+internal extension Permission {
+    var statusUserNotifications: PermissionStatus {


Could we keep the structure of the Motion permission (that also uses "synchronous" calls) please ?

delba · 2017-03-05T21:10:49Z

Hi @mrgrauel, thanks a lot for the PR! There are a just few changes to do before merging though.
Thanks!

mrgrauel · 2017-03-06T08:31:35Z

Good Morning @delba, is it now as you want it?

mrgrauel

Changed

mrgrauel · 2017-03-08T11:28:33Z

Source/Permission.swift

    /// The permission to send notifications.
    open static func notifications(types: UIUserNotificationType, categories: Set<UIUserNotificationCategory>?) -> Permission {
-        let settings   = UIUserNotificationSettings(types: types, categories: categories)
-        let permission = Permission(type: .notifications(settings))
-        _notifications = permission


* for example if you add Permissions in an already existing application * user would be stuck in a deadlock

mrgrauel · 2017-04-05T07:14:06Z

@delba I changed everything. I dunno why it still says that a change request is open.

mrgrauel · 2017-05-03T08:00:40Z

@delba Hello?!?!?!

otymartin · 2017-06-10T23:56:48Z

@delba Has this issue been fixed? I still get these xcode 10 deprecation warnings. It wont compile with target iOS 10

rob5408 · 2017-06-16T19:14:41Z

^^ @delba Sorry about that, I thought I was on my fork. I know it doesn't actually merge the PR, but why does GitHub even give me the option. :\

zhuorantan · 2017-06-22T12:43:06Z

@delba Please merge this PR

pasevin · 2017-07-27T23:56:05Z

Losing hope :/

Jeehut · 2017-09-14T10:24:45Z

Hey everybody, I've given up on waiting for @delba to answer and merge our PRs. Instead I've integrated this PR into my fork (which I created for #94). I've also created my own CocoaPods entry so we can continue using this framework and merging our improvements together. Feel free to star and send your PRs to my fork in the future. I will try to review them from time to time:
https://github.com/Dschee/Permission

To switch to my fork in your project simply replace pod 'Permission' with pod 'Dschee-Permission' if you are using CocoaPods or github "delba/Permission" with github "Dschee/Permission" if your are using Carthage. I've also made a new release: v2.1.0.

otymartin · 2017-09-15T05:32:37Z

@Dschee nice move 👍

delba · 2019-11-12T14:40:19Z

Hi @mrgrauel, the project has been updated to the latest Swift version and now uses UserNotifications (https://github.com/delba/Permission/blob/master/Source/Types/Notifications.swift).

pasevin mentioned this pull request Feb 22, 2017

Needs UserNotifications framework support for iOS 10+ #97

Closed

delba requested changes Mar 5, 2017

View reviewed changes

mrgrauel commented Mar 8, 2017

View reviewed changes

Andreas Grauel added 10 commits April 5, 2017 07:56

implement UserNotifications for iOS10+

ce32dd4

fix calling wrong method

03eeb64

rename permission

7289c10

add private static var for permission

4078151

update permissions as requested by maintainer

552985b

fix if permission granted before using permission

a56585f

fixes potential deadlock

63e30db

use granted variable for status

df2aca0

add timer if UserDefault is not set

68d3afb

* for example if you add Permissions in an already existing application * user would be stuck in a deadlock

add missing description

01e4592

remove extra whitespace

6538fac

rob5408 approved these changes Jun 16, 2017

View reviewed changes

Jeehut mentioned this pull request Sep 14, 2017

PermissionButton improvements #94

Open

2 tasks

delba closed this Nov 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add UserNotifications Framework for iOS 10+ #90

Add UserNotifications Framework for iOS 10+ #90

mrgrauel commented Jan 20, 2017

mrgrauel commented Jan 20, 2017

mrgrauel commented Jan 31, 2017

pasevin commented Feb 5, 2017

delba Mar 5, 2017

delba Mar 5, 2017

mrgrauel Mar 8, 2017

mrgrauel Mar 8, 2017

delba Mar 5, 2017

mrgrauel Mar 8, 2017

delba Mar 5, 2017

mrgrauel Mar 8, 2017

delba Mar 5, 2017

delba Mar 5, 2017

delba Mar 5, 2017

delba Mar 5, 2017

delba Mar 5, 2017

delba commented Mar 5, 2017

mrgrauel commented Mar 6, 2017

mrgrauel left a comment

mrgrauel Mar 8, 2017

mrgrauel commented Apr 5, 2017

mrgrauel commented May 3, 2017

otymartin commented Jun 10, 2017 •

edited

Loading

rob5408 commented Jun 16, 2017

zhuorantan commented Jun 22, 2017

pasevin commented Jul 27, 2017 •

edited

Loading

Jeehut commented Sep 14, 2017 •

edited

Loading

otymartin commented Sep 15, 2017

delba commented Nov 12, 2019

Add UserNotifications Framework for iOS 10+ #90

Add UserNotifications Framework for iOS 10+ #90

Conversation

mrgrauel commented Jan 20, 2017

mrgrauel commented Jan 20, 2017

mrgrauel commented Jan 31, 2017

pasevin commented Feb 5, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

delba commented Mar 5, 2017

mrgrauel commented Mar 6, 2017

mrgrauel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mrgrauel commented Apr 5, 2017

mrgrauel commented May 3, 2017

otymartin commented Jun 10, 2017 • edited Loading

rob5408 commented Jun 16, 2017

zhuorantan commented Jun 22, 2017

pasevin commented Jul 27, 2017 • edited Loading

Jeehut commented Sep 14, 2017 • edited Loading

otymartin commented Sep 15, 2017

delba commented Nov 12, 2019

otymartin commented Jun 10, 2017 •

edited

Loading

pasevin commented Jul 27, 2017 •

edited

Loading

Jeehut commented Sep 14, 2017 •

edited

Loading