Upgrade to nltk 3.9.1 to address CVE-2024-39705 #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upgrade to nltk to version 3.9.1 is a BREAKING change. This change downloads `punkt_tab` instead of `punkt` which has a critical security vulnerability (CVE-2024-39705). See e.g.: - GHSA-cgvx-9447-vcch - nltk/nltk#3293 - nltk/nltk#3266
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #75 +/- ##
=======================================
Coverage 87.15% 87.15%
=======================================
Files 40 40
Lines 1760 1760
=======================================
Hits 1534 1534
Misses 226 226 ☔ View full report in Codecov by Sentry. |
|
Merging to main branch, will have a new release soon. |
|
Thanks, @chrisk21! |
aecio
added a commit
to VIDA-NYU/bdi-kit
that referenced
this pull request
Nov 11, 2024
This reverts the version pin added in commit: bfc5f32 This can be done now since some of our dependencies, such as `valentine` have upgraded as well. See pull request delftdata/valentine#75. The minimum version requirement for valentine is needed because the ntlk upgrade is a breaking change: using valentine with older nltk would cause bugs related to the punkt tokenizer.
aecio
added a commit
to VIDA-NYU/bdi-kit
that referenced
this pull request
Nov 11, 2024
This reverts the version pin added in commit: bfc5f32 This can be done now since some of our dependencies, such as `valentine` have upgraded as well. See pull request delftdata/valentine#75. The minimum version requirement for valentine is needed because the ntlk upgrade is a breaking change: using valentine with older nltk would cause bugs related to the punkt tokenizer.
aecio
added a commit
to VIDA-NYU/bdi-kit
that referenced
this pull request
Nov 11, 2024
This reverts the version pin added in commit: bfc5f32 This can be done now since some of our dependencies, such as `valentine` have upgraded as well. See pull request delftdata/valentine#75. The minimum version requirement for valentine is needed because the ntlk upgrade is a breaking change: using valentine with older nltk would cause bugs related to the punkt tokenizer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade to nltk to version 3.9.1 is a BREAKING change. This change downloads
punkt_tabinstead ofpunktwhich has a critical security vulnerability (CVE-2024-39705).See e.g.: