Handling of connection failures #196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds circuit breaking behaviour to lymph when selecting endpoints to serve a request. The breaker tries to discern global failures, instance failures and failures due to method implementations correctly.
lymph.core.connection.Connection pings the endpoint regularly to determine whether it is still live. `__init__` takes a `unresponsive_disconnect` parameter, which was however ignored so far. Similarly, the `idle_disconnect` parameter did not have any effect. This commit uses thees two parameters to do what they advertise, i.e. close the connection once the respective timeouts have been reached. A control-flow bug which caused the monitoring greenlet to commit suicide before deregistering the connection from the server was also fixed, and a comment to that effect added.
Before this commit, connections which were never successfully connected remained UNRESPONSIVE indefinitely, repeatedly trying to ping the (non-connected) endpoint. Such connections are now moved to UNRESPONSIVE and unresponsive_timeout triggers as usual.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the next iteration of failure handling, taking the discussion of #172 into account.
lymph requests)