Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADS diff mode enhancements #136

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

Bhavneet-Sharma
Copy link
Collaborator

Description

ADS diff mode enhancements

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit Test
  • Functional Test

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.98%. Comparing base (c5b1405) to head (d2b5e6e).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
plugins/modules/nfs.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
+ Coverage   81.90%   84.98%   +3.07%     
==========================================
  Files         124      133       +9     
  Lines       13463    14876    +1413     
  Branches     1989     2168     +179     
==========================================
+ Hits        11027    12642    +1615     
+ Misses       1830     1611     -219     
- Partials      606      623      +17     
Flag Coverage Δ
units 84.98% <81.81%> (+3.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Bhavneet-Sharma Bhavneet-Sharma merged commit d6a589a into dell:main Nov 20, 2024
22 checks passed
@Bhavneet-Sharma Bhavneet-Sharma deleted the ads-diff-enhancements branch November 20, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants