Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image version update workflow #122

Merged
merged 11 commits into from
Feb 11, 2025
Merged

Add image version update workflow #122

merged 11 commits into from
Feb 11, 2025

Conversation

ashleyvjoy
Copy link
Contributor

Description

A github action is created that will handle updating image version in driver and module repositories Dockerfiles

Issues

List the issues impacted by this PR:

| Issue ID |
| dell/csm#1490 |

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested this with a fork and ensured that the action creates a PR for code-owners to review
image-update-workflow workflow-2 workflow-3

shaynafinocchiaro
shaynafinocchiaro reviewed Feb 3, 2025
View reviewed changes
.github/workflows/image-version-workflow.yaml Outdated Show resolved Hide resolved
.github/workflows/image-version-workflow.yaml Outdated Show resolved Hide resolved
.github/workflows/trigger-image-version-workflow.yaml Outdated Show resolved Hide resolved
.github/workflows/trigger-image-version-workflow.yaml Outdated Show resolved Hide resolved
.github/workflows/image-version-workflow.yaml Outdated Show resolved Hide resolved
@shaynafinocchiaro
Copy link
Contributor

Can you update the README for how this action will be invoked?

harishp8889
harishp8889 previously approved these changes Feb 6, 2025
View reviewed changes
mgandharva
mgandharva previously approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@mgandharva mgandharva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

meggm
meggm previously approved these changes Feb 7, 2025
View reviewed changes
donatwork
donatwork previously approved these changes Feb 7, 2025
View reviewed changes
.github/workflows/image-version-workflow.yaml Outdated Show resolved Hide resolved
@ashleyvjoy ashleyvjoy merged commit 684bc07 into main Feb 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harishp8889 harishp8889 harishp8889 approved these changes

@meggm meggm meggm approved these changes

@shaynafinocchiaro shaynafinocchiaro shaynafinocchiaro approved these changes

@AronAtDell AronAtDell Awaiting requested review from AronAtDell AronAtDell is a code owner

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell ChristianAtDell is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@donatwork donatwork Awaiting requested review from donatwork donatwork is a code owner

@mgandharva mgandharva Awaiting requested review from mgandharva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ashleyvjoy @shaynafinocchiaro @harishp8889 @donatwork @meggm @mgandharva