Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add go version workflow #46

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Add go version workflow #46

merged 2 commits into from
Oct 8, 2024

Conversation

falfaroc
Copy link
Contributor

@falfaroc falfaroc commented Oct 7, 2024 •
edited
Loading

Description

Add caller workflow Go Version Update. It can be manually triggered or it can be triggered by Trigger Go Version Workflow.

Why suppress G115?

  • At some point in the flow, casting to int64 will be needed when assigning to a csi struct.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1490

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

@falfaroc falfaroc merged commit 33db64f into main Oct 8, 2024
4 checks passed
@suryagupta4 suryagupta4 deleted the add-go-version-workflow branch November 4, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitesh3108 nitesh3108 nitesh3108 approved these changes

@shaynafinocchiaro shaynafinocchiaro shaynafinocchiaro approved these changes

@harishp8889 harishp8889 harishp8889 approved these changes

@kumarp20 kumarp20 Awaiting requested review from kumarp20 kumarp20 is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@xuluna xuluna Awaiting requested review from xuluna xuluna is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@KerryKovacevic KerryKovacevic Awaiting requested review from KerryKovacevic KerryKovacevic is a code owner

@EvgenyUglov EvgenyUglov Awaiting requested review from EvgenyUglov EvgenyUglov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@falfaroc @harishp8889 @shaynafinocchiaro @nitesh3108