Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New error for VG-removeMember #139

Merged
merged 1 commit into from
Oct 3, 2024
Merged

New error for VG-removeMember #139

merged 1 commit into from
Oct 3, 2024

Conversation

santhoshatdell
Copy link
Contributor

@santhoshatdell santhoshatdell commented Oct 1, 2024

PR Submission checklist

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1443

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained backward compatibility

Description of your changes:

Added new error for dell/csi-powerstore#347 as idempotency check.

Tested along with powerstore driver changes.
Unit tests added (coverage: 81.9% of statements).

@santhoshatdell santhoshatdell changed the title Added new error for VG-removeMember New error for VG-removeMember Oct 2, 2024
@santhoshatdell santhoshatdell marked this pull request as ready for review October 2, 2024 13:36
Copy link
Contributor

@lukeatdell lukeatdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Santhosh!

@santhoshatdell santhoshatdell merged commit cdc576f into main Oct 3, 2024
4 checks passed
@santhoshatdell santhoshatdell deleted the metro-vg branch October 3, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants