Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds powermax as driver, unit, int and scale test #199

Merged
merged 3 commits into from
May 14, 2024

Conversation

delldubey
Copy link
Contributor

Description

  • Adds CSI Pwermax as supported driver
  • Adds Unit, Int, and scale tests

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1082

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [x[ I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit Test

  • PASS
    coverage: 92.4% of statements
    status 0 ok podmon/internal/monitor 12.436s coverage: 92.4% of statements
    PASS
    coverage: 96.8% of statements
    status 0 ok podmon/cmd/podmon 1.575s coverage: 96.8% of statements

  • Integration test

  • image

Copy link
Contributor

@AkshaySainiDell AkshaySainiDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@adarsh-dell adarsh-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@delldubey delldubey merged commit 7456c1c into main May 14, 2024
7 checks passed
@anandrajak1 anandrajak1 deleted the feature-pmaxSupport branch October 17, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants