Update ansible-lint.yml

.config/ansible-lint.yml

@@ -0,0 +1,36 @@
+---
+exclude_paths:
+  - .git/
+  - .github/
+  - accelerator/tests/
+  - network/
+  - provision/tests/
+  - scheduler/
+  - security/tests/
+  - storage/tests/
+  - test/
+  - utils/test/
+  - utils/obsolete/
+  - utils/cluster/
+  - utils/k8s-upgrade/
+  - docs/
+  - test/
+  - input/
+  - platforms/
+  - examples/
+  - .ansible-lint.yml
+  - .readthedocs.yaml
+
+warn_list:
+  - yaml
+  - meta-no-info
+  - meta-incorrect
+  - fqcn-builtins
+
+skip_list:
+  - var-naming[no-role-prefix]
+  - fqcn[action-core]
+  - unresolved-module
+
+verbosity: 1
+profile: production

.config/requirements.yml

@@ -0,0 +1,25 @@
+---
+collections:
+  - name: ansible.utils
+    version: 5.1.1
+  - name: community.crypto
+    version: 2.22.0
+  - name: community.docker
+    version: 3.12.1
+  - name: community.general
+    version: 9.4.0
+  - name: community.grafana
+    version: 2.1.0
+  - name: community.mysql
+    version: 3.10.3
+  - name: community.postgresql
+    version: 3.5.0
+  - name: dellemc.os10
+    version: 1.1.1
+  - name: dellemc.openmanage
+    version: 9.6.0
+  - name: kubernetes.core
+    version: 5.0.0
+  - name: https://github.com/kubernetes-sigs/kubespray
+    type: git
+    version: v2.25.0

.github/workflows/ansible-lint.yml

@@ -15,80 +15,27 @@ on:
       - release-1.5.1
       - release-1.6
       - release-1.7
+      - staging
+      - release-1.7.1
+      - pub/new_architecture
 
 jobs:
-  ansible-lint:
-
+  build:
+    name: Ansible Lint # Naming the build is important to use it as a status check
     runs-on: ubuntu-latest
-
     steps:
-    # Important: This sets up your GITHUB_WORKSPACE environment variable
-    - uses: actions/checkout@v2
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Install Ansible collections
+        run: |
+          python3 -m pip install --upgrade pip
+          pip install ansible
 
-    - name: ansible-lint 
-      # replace "master" with any valid ref
-      uses: ansible/ansible-lint-action@c37fb7b4bda2c8cb18f4942716bae9f11b0dc9bc
-      with:
-        # [required]
-        # Paths to ansible files (i.e., playbooks, tasks, handlers etc..)
-        # or valid Ansible directories according to the Ansible role
-        # directory structure.
-        # If you want to lint multiple ansible files, use the following syntax
-        # targets: |
-        #   playbook_1.yml
-        #   playbook_2.yml
-        targets: |
-          /github/workspace/omnia.yml
-          /github/workspace/discovery_provision.yml
-          /github/workspace/local_repo/local_repo.yml
-          /github/workspace/server_spec_update/server_spec_update.yml
-          /github/workspace/scheduler/job_based_user_access.yml
-          /github/workspace/security/user_passwordless_ssh.yml
-          /github/workspace/storage/nfs_sas.yml
-          /github/workspace/storage/powervault.yml
-          /github/workspace/telemetry/add_node_idrac.yml
-          /github/workspace/tools/jupyterhub.yml
-          /github/workspace/tools/kserve.yml
-          /github/workspace/tools/kubeflow.yml
-          /github/workspace/tools/pytorch.yml
-          /github/workspace/tools/tensorflow.yml
-          /github/workspace/tools/vllm.yml
-          /github/workspace/utils/control_plane_cleanup.yml
-          /github/workspace/utils/delete_node.yml
-          /github/workspace/utils/remove_node_configuration.yml
-          /github/workspace/utils/reset_cluster_configuration.yml
-          /github/workspace/utils/update_user_repo.yml
-          /github/workspace/utils/servicetag_host_mapping.yml
-          /github/workspace/utils/software_update/software_update.yml
-          /github/workspace/utils/timescaledb_utility/timescaledb_utility.yml
-          /github/workspace/utils/ip_rule_assignment/ip_rule_assignment.yml
-          /github/workspace/utils/nodeinfo_db/nodeinfo_db.yml
-          # [optional]
-        # Arguments to override a package and its version to be set explicitly.
-        # Must follow the example syntax.
-        override-deps: |
-          ansible==6.7.0
-          ansible-lint==6.13.1
-        # [optional]
-        # Arguments to be passed to the ansible-lint
+      # - name: Install Ansible collections
+      #   run: ansible-galaxy collection install -r .config/requirements.yml
 
-        # Options:
-        #   -q                    quieter, although not silent output
-        #   -p                    parseable output in the format of pep8
-        #   --parseable-severity  parseable output including severity of rule
-        #   -r RULESDIR           specify one or more rules directories using one or
-        #                         more -r arguments. Any -r flags override the default
-        #                         rules in ansiblelint/rules, unless -R is also used.
-        #   -R                    Use default rules in ansiblelint/rules in addition to
-        #                         any extra
-        #                         rules directories specified with -r. There is no need
-        #                         to specify this if no -r flags are used
-        #   -t TAGS               only check rules whose id/tags match these values
-        #   -x SKIP_LIST          only check rules whose id/tags do not match these
-        #                         values
-        #   --nocolor             disable colored output
-        #   --exclude=EXCLUDE_PATHS
-        #                         path to directories or files to skip. This option is
-        #                         repeatable.
-        #   -c C                  Specify configuration file to use. Defaults to ".ansible-lint"
-        args: "-x 305"
+      - name: Run ansible-lint
+        uses: ansible/[email protected]
+        with:
+          args: --config=.config/ansible-lint.yml

.readthedocs.yaml

@@ -21,11 +21,11 @@ sphinx:
 
 # If using Sphinx, optionally build your docs in additional formats such as PDF
 formats:
-   - pdf
-   - epub
-   - htmlzip
+  - pdf
+  - epub
+  - htmlzip
 
 # Optionally declare the Python requirements required to build your docs
 python:
   install:
-    - requirements: docs/source/requirements.txt
+    - requirements: docs/source/requirements.txt

accelerator/roles/intel/tasks/make_sure_scale_out_interfaces_up.yml

@@ -40,7 +40,7 @@
 - name: Create bring_up_ports.sh
   when: not check_bring_up_script.stat.exists
   ansible.builtin.blockinfile:
     path: "{{ intel_bring_up_ports_script_path }}"
     create: true
     mode: "{{ file_permissions }}"
     block: |
@@ -76,4 +76,3 @@
     name: "Bring up Gaudi ports"
     special_time: reboot
     job: "{{ intel_bring_up_ports_script_path }}"
-

accelerator/roles/nvidia/tasks/install_cuda_redhat.yml

@@ -30,7 +30,7 @@
   changed_when: true
 
 - name: Enable EPEL Repo
-  ansible.builtin.yum:
+  ansible.builtin.yum: # noqa fqcn[action-core]
     name: https://dl.fedoraproject.org/pub/epel/epel-release-latest-8.noarch.rpm
     state: present
     disable_gpg_check: true
@@ -39,7 +39,7 @@
   when: hostvars['localhost']['local_installer']
   block:
     - name: Install packages from cuda rpm file
-      ansible.builtin.yum:
+      ansible.builtin.yum: # noqa fqcn[action-core]
         name: "{{ cuda_filepath }}"
         state: present
         disable_gpg_check: true

discovery/roles/configure_xcat/redhat/tasks/omnia_repo_config.yml

@@ -70,7 +70,7 @@
         dest: "{{ omnia_common_xcat_repo }}"
         mode: "{{ file_permission }}"
   rescue:
-    - name:  Warning - Failed to download racadm package
+    - name: Warning - Failed to download racadm package
       ansible.builtin.pause:
         prompt: "{{ download_racadm_warning_msg }}"
         seconds: "{{ warning_time }}"

discovery/roles/configure_xcat/ubuntu/tasks/racadm_config.yml

@@ -30,7 +30,7 @@
       until: download_racadm is not failed
       retries: "{{ max_retries }}"
   rescue:
-    - name:  Warning - Failed to download racadm package
+    - name: Warning - Failed to download racadm package
       ansible.builtin.pause:
         prompt: "{{ download_racadm_warning_msg }}"
         seconds: "{{ warning_time }}"

discovery/roles/configure_xcat/ubuntu/vars/main.yml

@@ -44,8 +44,7 @@ racadm_tar_url: "https://dl.dell.com/FOLDER08952875M/1/Dell-iDRACTools-Web-LX-11
 tarball_path: "{{ repo_store_path }}/cluster/tarball/"
 racadm_tar_dest: "{{ tarball_path }}/racadm.tar.gz"
 max_retries: 10
-download_racadm_warning_msg: "[WARNING] Failed to download racadm package {{ racadm_tar_url }}. This can be due to internet connectivity issue. Please verify the connectivity and try again.
-Skipping racadm configuration in the cluster."
+download_racadm_warning_msg: "[WARNING] Failed to download racadm package {{ racadm_tar_url }}. This can be due to internet connectivity issue. Please verify the connectivity and try again. Skipping racadm configuration in the cluster." # noqa yaml[line-length]
 warning_time: 30
 
 # Usage: configure_kernel.yml

discovery/roles/discovery_mechanism/common/vars/main.yml

@@ -31,6 +31,6 @@ dns_config_warning_msg: "[WARNING] makedns -n command is not successful. Error:"
 xcat_sbin_path: /opt/xcat/sbin
 
 # Usage: remove_old_ssh_key.yml
-empty_discover_node_msg: | 
+empty_discover_node_msg: |
   "Failed. No nodes were discovered. Please ensure the input related to discovery details is correct inside provision_config.yml and network_spec.yml
    and check if IPMI is enabled on the nodes if using BMC discovery mechanism."

discovery/roles/os_update/tasks/set_kernel_params.yml

@@ -54,7 +54,7 @@
   when: cmdline_value != ""
   block:
     - name: Servicetag Host mapping and run chdef command
-      ansible.builtin.command: "{{ python_version }} {{ servicetag_node_mapping_script }} {{ role_path }} {{ file_path }} {{ inventory_hostname_short }} {{ cmdline_value | quote }}"
+      ansible.builtin.command: "{{ python_version }} {{ servicetag_node_mapping_script }} {{ role_path }} {{ file_path }} {{ inventory_hostname_short }} {{ cmdline_value | quote }}" # noqa yaml[line-length]
       register: chdef_result
       changed_when: true
 

discovery/roles/postscripts/common/vars/main.yml

@@ -38,7 +38,7 @@ ubuntu_reboot_script_path:
 
 # Usage: configure_postsctipts_ntp.yml
 setup_ntp_warning_msg: "[WARNING] Failed to setup NTP server in Omnia Infrastructure Manager. This can be due to public NTP pools blocked via ICMP.
-Skipping NTP configuration in the cluster. If public NTP pools not reachable from Omnia Infrastructure Manager, set ntp_support to false in provison_config.yml."
+Skipping NTP configuration in the cluster. If public NTP pools not reachable from Omnia Infrastructure Manager, set ntp_support to false in provison_config.yml." # noqa yaml[line-length]
 warning_time: 30
 async_time: 300
 poll_time: 15

discovery_provision.yml

@@ -32,7 +32,7 @@
     - name: Set flag to indicate check_package_lock.yml has been executed
       ansible.builtin.set_fact:
         apt_lock_status: true
-    
+
     - name: Set inventory_status
       ansible.builtin.set_fact:
         inventory_status: true
@@ -43,7 +43,7 @@
 
     - name: Validate inventory file
       include_role:
         name: utils/server_spec_update/roles/server_spec_validation
       when: inventory_status | default(false) | bool
 
 - name: Validate discovery parameters                            # noqa:role-name[path]

requirements.yml

@@ -0,0 +1,25 @@
+---
+collections:
+  - name: ansible.utils
+    version: 5.1.1
+  - name: community.crypto
+    version: 2.22.0
+  - name: community.docker
+    version: 3.12.1
+  - name: community.general
+    version: 9.4.0
+  - name: community.grafana
+    version: 2.1.0
+  - name: community.mysql
+    version: 3.10.3
+  - name: community.postgresql
+    version: 3.5.0
+  - name: dellemc.os10
+    version: 1.1.1
+  - name: dellemc.openmanage
+    version: 9.6.0
+  - name: kubernetes.core
+    version: 5.0.0
+  - name: https://github.com/kubernetes-sigs/kubespray
+    type: git
+    version: v2.25.0